PAYARA-1904 Add jndi to get set ordinal commands #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
|
Quick build and test passed! |
Since there is a default for the source, it should be optional or the default can't be used.
Since there is a default for the source, it should be optional or the default can't be used.
Since there is a default for the source, it should be optional or the default can't be used.
Since there is a default for the source, it should be optional or the default can't be used.
|
set/get-config-property also need to support jndi |
smillidge
approved these changes
Aug 3, 2017
|
jenkins test please |
|
Quick build and test passed! |
|
Jenkins test please |
|
Quick build and test passed! |
michaelranaldo
pushed a commit
to michaelranaldo/Payara
that referenced
this pull request
Sep 12, 2017
PAYARA-1904 * add-jndi-to-get-set-ordinal-commands * add cases to switches * source should be optional Since there is a default for the source, it should be optional or the default can't be used. * source should be optional Since there is a default for the source, it should be optional or the default can't be used. * Source should be optional Since there is a default for the source, it should be optional or the default can't be used. * Source should be optional Since there is a default for the source, it should be optional or the default can't be used. * Clarify error text for ambiguous sourceName property * Clarify error text for ambiguous sourceName property * jndi source for set-config-property * slightly modify JNDI setter and add getter * removed prefix and added support for targets to getter
michaelranaldo
pushed a commit
to michaelranaldo/Payara
that referenced
this pull request
Sep 25, 2017
PAYARA-1904 * add-jndi-to-get-set-ordinal-commands * add cases to switches * source should be optional Since there is a default for the source, it should be optional or the default can't be used. * source should be optional Since there is a default for the source, it should be optional or the default can't be used. * Source should be optional Since there is a default for the source, it should be optional or the default can't be used. * Source should be optional Since there is a default for the source, it should be optional or the default can't be used. * Clarify error text for ambiguous sourceName property * Clarify error text for ambiguous sourceName property * jndi source for set-config-property * slightly modify JNDI setter and add getter * removed prefix and added support for targets to getter
michaelranaldo
pushed a commit
to michaelranaldo/Payara
that referenced
this pull request
Sep 25, 2017
PAYARA-1904 Add jndi to get set ordinal commands (payara#1833)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.