GLASSFISH-21261 #92
Merged
GLASSFISH-21261 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public static void setFileProperties() | ||
| { | ||
| if(System.getProperty("com.sun.appserv.winFileLockRetryLimit")!=null || System.getProperty("com.sun.appserv.winFileLockRetryLimit")!="" ) |
There was a problem hiding this comment.
that's a very strange condition. perhaps it should be && instead of || ?
There was a problem hiding this comment.
You can simplify it by
Integer retryCounter = Integer.getInteger("com.sun.appserv.winFileLockRetryLimit");
if (retryCounter != null && retryCounter > 0) {
FILE_OPERATION_MAX_RETRIES=retryCounter;
}
|
I'm pretty sure it will throw NPE if the property "com.sun.appserv.winFileLockRetryLimit" is unset. |
|
Ok will modify. Thanks. |
|
Thanks: #96 |
|
np, I like to see Glassfish is live and kicking! |
michaelranaldo
pushed a commit
to michaelranaldo/Payara
that referenced
this pull request
Sep 25, 2017
PAYARA-1904 Add jndi to get set ordinal commands (payara#1833)
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Jun 30, 2020
Missed pom increments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.