-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Docusaurus + Add Articles #63
Conversation
After discussion with @DanGould, it was agreed to revert any copy changes and and not to introduce any new content changes, so that this PR can instead focus on underlying structural changes to docusaurus to the extent possible, to reduce the amount of changes being introduced in one PR. However, since this is a major structural change to the underlying website code, this having many changes at once is inevitable to an extent. To that end, I kept the content nearly exactly the same as the current website. The homepage remains mostly the same, with the following changes:
Overall, I think this move will allow us to focus on the bigger picture and iterate on content much faster and not get stuck in minutiae of styling & design decisions. Docusaurus still allows a great deal of flexibility if we choose to do that. I have tested all the links myself and they look good, let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is exactly what I was looking for. Getting all the content in the docusaurus format, even the old FAQ is killer.
There are just a few files (which I believe I left comments on) which are part of the template that will never be used in this project which I would like to see removed
blog/2019-05-29-long-blog-post.md
Outdated
|
||
<!--truncate--> | ||
|
||
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque elementum dignissim ultricies. Fusce rhoncus ipsum tempor eros aliquam consequat. Lorem ipsum dolor sit amet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it odd to commit Lorem ipsum
blog/2019-05-28-first-blog-post.md
Outdated
tags: [hola, docusaurus] | ||
--- | ||
|
||
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque elementum dignissim ultricies. Fusce rhoncus ipsum tempor eros aliquam consequat. Lorem ipsum dolor sit amet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lorem ipsum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oversight on my part, these template blog posts I originally intended to modify into our substack posts and came with the template docusaurus. We can add this later if we feel the need to.
blog/2021-08-01-mdx-blog-post.mdx
Outdated
tags: [docusaurus] | ||
--- | ||
|
||
Blog posts support [Docusaurus Markdown features](https://docusaurus.io/docs/markdown-features), such as [MDX](https://mdxjs.com/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we seem not to render this post
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not using this file, are we?
blog/2021-08-26-welcome/index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think when the site is linked this is going to show up. We may not want that
static/img/favicon.ico
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did the old favicon get replaced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these docusaurus images used?
{/* <div> | ||
<a href="https://payjoindevkit.org/" target="_blank"> | ||
<button className="font-extrabold bg-gradient-to-r bg-secondary border-white border-2 border-solid shadow-[0px_0px_10px_10px_rgba(0,0,0,0.3)] shadow-primary hover:scale-105 transition-all p-8 rounded-lg cursor-pointer text-5xl "> | ||
<span className="text-transparent bg-clip-text bg-gradient-to-r from-primary to-white"> | ||
Integrate Payjoin | ||
</span> | ||
</button> | ||
</a> | ||
</div> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this fancy "Integrate Payjoin" button for the time being in favor of maintaining parity with the current site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more unused files
# Ignore files for YARN | ||
yarn.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lock files ensure my build and your build use the same dependencies in different environments. AFAIK they are usually only ignored when developing libraries. Any reason to ignore here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is .prettierignore
, not .gitignore
. yarn.lock
is being committed, just not linted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hopefully we find some place to use this
static/img/docusaurus.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this used?
static/img/logo.svg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused?
It's live on payjoin.org and exceeds my expectation on mobile! I'm so stoked you pulled this one through. 🚀 The new arch is gonna 10x what we can do with the website BOOM. |
This is a massive PR change to completely restructure the site to use docusaurus, a docs-site generator with all sorts of built-in bells and whistles that is commonly used and familiar. It allows us to write our articles in markdown and handles routing/rendering automatically. I kept the home page as mostly the same as our current payjoin.org site with some enhancements (and removed a couple other things). I've also been using excalidraw to create explainer diagrams for payjoin v1/v2. You can see them all here.
This PR is not yet complete as I think we should write a couple of tutorials on how to use it (especially payjoin v2) as well as write some articles on building a send/receive payjoin. We can also discuss whether we want to port over PDK to this website and make it it's own dedicated page with tutorials and navigation (it can have it's own homepage on the same site, etc.) or whether we think it's better to keep them separate. I personally favor integrating everything we can for ease of access unless we feel the site is getting hard to navigate, but generally we should try to funnel people from very high level -> very technical in a naturally progressive way, which this docs site is designed to handle well. PDK website doesn't have much on it currently that would require porting, and I notice the actual API docs are outsourced to the rust documentation anyway, so we wouldn't be losing much in the port and would probably gain navigability.
We can also consider just putting the blog (or a blog) on payjoin updates on here, as well as podcast appearances, news, video tutorials, etc. Docusaurus comes with a sample blog built-in for reference, I think that would fit well here.
This took a lot of inspiration from fedimint's setup. I like a lot about how that project is setup, in addition, their Github is also very well organized.
Overall, this change will make it much easier for us to iterate on documentation and educational materials. Let me know what you think.