This repository has been archived by the owner on Jul 20, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dee-Pac
requested review from
aashish-sheshadri,
praveen-kanamarlapudi and
ayushiagarwal
August 24, 2018 16:36
aashish-sheshadri
approved these changes
Aug 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
4 tasks
4 tasks
This was referenced Aug 24, 2018
This was referenced Aug 27, 2018
4 tasks
This was referenced Aug 28, 2018
4 tasks
This was referenced Dec 6, 2018
Merged
4 tasks
Dee-Pac
pushed a commit
that referenced
this pull request
Dec 6, 2018
Make sure you have checked all steps below. ### GitHub Issue Fixes #58 ### Checklist: <!--- Go over all the following points. Check boxes that apply to this pull request --> - [ ] This pull request updates the documentation - [ ] This pull request changes library dependencies - [ ] Title of the PR is of format (example) : [#17] Add Issue Template <!-- NOTE: lines that start with < - - ! and end with - - > are comments and will be ignored. --> <!-- Please include the GitHub issue number in the PR title above. If an issue does not exist, please create one.--> <!-- Example:[#17] Add Issue Template, where [#17 refers to #17] --> ### What is the purpose of this pull request? <!-- Please fill in changes proposed in this pull request. --> <!-- Example: This Pull Request Adds Template Files for raising issues in github --> ### How was this change validated? <!-- Please add the Command Used, Results Snippet, details on how reviewer/committer can simulate issue & verify the change --> <!-- Example: In addition to unit-tests, and integration-test, I ran X on the Y cluster and verified the Z output.--> ### Commit Guidelines - [ ] My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how"
Merged
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Add Issue Template #14
This PR adds two templates : features & bugs. Having a standard template reduces back and forth on new issues, because all the mandatory questions are asked when someone opens a new issue
To feel how this will work -
-- goto https://github.com/Dee-Pac/PPExtensions/issues
-- click "New Issue" OR go here : https://github.com/Dee-Pac/PPExtensions/issues/new/choose