Skip to content
This repository has been archived by the owner on Jul 20, 2020. It is now read-only.

[#40] Sync develop branch with master #41

Merged
merged 3 commits into from
Aug 27, 2018
Merged

[#40] Sync develop branch with master #41

merged 3 commits into from
Aug 27, 2018

Conversation

praveen-kanamarlapudi
Copy link
Contributor

@praveen-kanamarlapudi praveen-kanamarlapudi commented Aug 27, 2018

Make sure you have checked all steps below.

GitHub Issue

Fixes #40

Checklist:

  • This pull request updates the documentation
  • This pull request changes library dependencies
  • Title of the PR is of format (example) : [[#14] Add Issue Template #17] Add Issue Template

What is the purpose of this pull request?

Moving all changes from master to develop, so the future pull requests will go to develop.

How was this change validated?

NA

Commit Guidelines

  • My commits all reference GH issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

* [#8] Add travis CI integration

* [#8] Add travis CI integration

* [#8] Add travis CI integration

* [#8] Add travis CI integration

* [#8] Add travis CI integration

* [#8] Add travis CI integration

* [#8] Add travis CI integration
Copy link
Contributor

@ayushiagarwal ayushiagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushiagarwal ayushiagarwal merged commit 7c746ce into develop Aug 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants