customize calc namespace to have most used function at the top level #375
Conversation
|
I believe these tests were failing due to pcdscalc not being updated on condaforge yet, so I'm giving them a kick |
| be_lens=collect_functions(['pcdscalc.be_lens_calcs']), | ||
| common=collect_functions(['pcdscalc.common']), | ||
| diffraction=collect_functions(['pcdscalc.diffraction']), | ||
| xray=collect_functions(['pcdscalc.xray']) | ||
| xray=collect_functions(['pcdscalc.xray']), |
There was a problem hiding this comment.
Isn't pcdscalc.xray new? collect_functions will try to import it and raise if I understand correctly. That means it probably should have similar handling as funcs
There was a problem hiding this comment.
I agree, I think we need to be consistent here: either everything in this module retains backwards compatibility with old versions as implemented above, OR we jettison all of this complexity and simply update the dependency pin on pcdscalc.
There was a problem hiding this comment.
I don't really have a strong preference here. This module is widely underutilized across the hutches at the moment, so I dont think it will create much chaos to just move forward with a dependency update
There was a problem hiding this comment.
I personally think either way is totally reasonable
Description
Make calc namespace more useful.
Motivation and Context
The scientist wants the most used calc function to be readily accessible under the calc namespace.
Note: still waiting on more input from the scientists regarding which functions they want.
How Has This Been Tested?
In xpp3
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
docs/pre-release-notes.shand created a pre-release documentation page