-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: XPP calc namespace hotfix #390
Conversation
This supersedes #375 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks rather unobjectionable. With an updated pcdscalc, this bypasses many of the issues from #375
Vincent is on vacation through the end of them month, so I'm going to merge this now and ask him to double-check when he gets back. But this should be pretty uncontroversial. |
Description
In #375 and in xpp3 dev there are some updates to the calc namespace.
xpp3 dev is slightly ahead in some ways and slightly behind in some others.
In this PR, I:
Motivation and Context
How Has This Been Tested?
Where Has This Been Documented?
Pre-release notes and PR only
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page