Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: XPP calc namespace hotfix #390

Merged
merged 10 commits into from
Oct 15, 2024
Merged

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Oct 15, 2024

Description

In #375 and in xpp3 dev there are some updates to the calc namespace.
xpp3 dev is slightly ahead in some ways and slightly behind in some others.

In this PR, I:

Motivation and Context

How Has This Been Tested?

image

Where Has This Been Documented?

Pre-release notes and PR only

Pre-merge checklist

  • Code works interactively (a real hutch config file can be loaded)
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@ZLLentz
Copy link
Member Author

ZLLentz commented Oct 15, 2024

This supersedes #375

@ZLLentz ZLLentz marked this pull request as ready for review October 15, 2024 01:23
@ZLLentz ZLLentz requested review from tangkong and vespos October 15, 2024 01:23
Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks rather unobjectionable. With an updated pcdscalc, this bypasses many of the issues from #375

@ZLLentz
Copy link
Member Author

ZLLentz commented Oct 15, 2024

Vincent is on vacation through the end of them month, so I'm going to merge this now and ask him to double-check when he gets back. But this should be pretty uncontroversial.

@ZLLentz ZLLentz merged commit b978c6e into pcdshub:master Oct 15, 2024
11 checks passed
@ZLLentz ZLLentz deleted the enh_xpp_calc_ns branch October 15, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants