Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use code-style enforcement #312

Closed
pietermarsman opened this issue Oct 22, 2019 · 2 comments · Fixed by #345
Closed

Use code-style enforcement #312

pietermarsman opened this issue Oct 22, 2019 · 2 comments · Fixed by #345
Labels
type: development Related to the development process for maintainers

Comments

@pietermarsman
Copy link
Member

A lot of files in this project don't follow PEP8.

I would like to have some code-style enforcement in this project because (for me) it makes the code more readable and maintainable.

I've earlier worded with flake8 and think it works really well.

Also see this earlier (closed) PR: #92.
@pietermarsman pietermarsman added the type: development Related to the development process for maintainers label Oct 22, 2019
@pietermarsman pietermarsman mentioned this issue Oct 22, 2019
Closed
@c4xuxo
Copy link

c4xuxo commented Nov 3, 2019

Will see when I can have a look into this.

@pietermarsman
Copy link
Member Author

OK, nice! Also see #316 .

pietermarsman pushed a commit that referenced this issue Nov 11, 2019
@fakabbir @pietermarsman
Code Refractor: Use code-style enforcement #312
507eac0
@fakabbir fakabbir mentioned this issue Dec 7, 2019
Merged
5 tasks
@pietermarsman pietermarsman mentioned this issue Dec 29, 2019
Merged
5 tasks
pietermarsman added a commit that referenced this issue Dec 29, 2019
@pietermarsman @fakabbir
Enforce pep8 coding-style (#345)
f3ab1bc 
* Code Refractor: Use code-style enforcement #312

* Add flake8 to travis-ci

* Remove python 2 3 comment on six library. 891 errors > 870 errors.

* Remove class and functions comments that consist of just the name. 870 errors > 855 errors.

* Fix flake8 errors in pdftypes.py. 855 errors > 833 errors.

* Moving flake8 testing from .travis.yml to tox.ini to ensure local testing before commiting

* Cleanup pdfinterp.py and add documentation from PDF Reference

* Cleanup pdfpage.py

* Cleanup pdffont.py

* Clean psparser.py

* Cleanup high_level.py

* Cleanup layout.py

* Cleanup pdfparser.py

* Cleanup pdfcolor.py

* Cleanup rijndael.py

* Cleanup converter.py

* Rename klass to cls if it is the class variable, to be more consistent with standard practice

* Cleanup cmap.py

* Cleanup pdfdevice.py

* flake8 ignore fontmetrics.py

* Cleanup test_pdfminer_psparser.py

* Fix flake8 in pdfdocument.py; 339 errors to go

* Fix flake8 utils.py; 326 errors togo

* pep8 correction for few files in /tools/ 328 > 160 to go (#342)

* pep8 correction for few files in /tools/ 328 > 160 to go

* pep8 correction: 160 > 5 to go

* Fix ascii85.py errors

* Fix error in getting index from target that does not exists

* Remove commented print lines

* Fix flake8 error in pdfinterp.py

* Fix python2 specific error by removing argument from print statement

* Ignore invalid python2 syntax

* Update contributing.md

* Added changelog

* Remove unused import

Co-authored-by: Fakabbir Amin <f4amin@gmail.com>
@pietermarsman pietermarsman mentioned this issue Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: development Related to the development process for maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce pep8 coding style pdfminer/pdfminer.six
2 participants
@pietermarsman @c4xuxo