Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce pep8 coding style #345

Merged
merged 34 commits into from
Dec 29, 2019
Merged

Enforce pep8 coding style #345

merged 34 commits into from
Dec 29, 2019

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented Dec 29, 2019 •
edited
Loading

Description

Fix pep8 and other code-style issues.

Fixes #312
Successor of #92

How Has This Been Tested?

By adding flake8 tests to the .gitlab-ci.yml.
Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the README.md and other documentation, or I am sure that this is not necessary
  • I have added a consice human-readable description of the change to CHANGELOG.md
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial version

fakabbir and others added 30 commits November 11, 2019 16:55
@fakabbir @pietermarsman
Code Refractor: Use code-style enforcement #312
507eac0
@pietermarsman
Add flake8 to travis-ci
88bbd3e
@pietermarsman
Remove python 2 3 comment on six library. 891 errors > 870 errors.
459e429
@pietermarsman
Remove class and functions comments that consist of just the name. 87…
8c22cdf 
…0 errors > 855 errors.
@pietermarsman
Fix flake8 errors in pdftypes.py. 855 errors > 833 errors.
51d0927
@pietermarsman
Moving flake8 testing from .travis.yml to tox.ini to ensure local tes…
8995074 
…ting before commiting
@pietermarsman
Cleanup pdfinterp.py and add documentation from PDF Reference
2f216f5
@pietermarsman
Cleanup pdfpage.py
fc6acfc
@pietermarsman
Cleanup pdffont.py
cc89a37
@pietermarsman
Clean psparser.py
cf93de4
@pietermarsman
Cleanup high_level.py
cb05ae7
@pietermarsman
Cleanup layout.py
bf3de47
@pietermarsman
Cleanup pdfparser.py
ed65566
@pietermarsman
Cleanup pdfcolor.py
9aea68b
@pietermarsman
Cleanup rijndael.py
3f19e17
@pietermarsman
Cleanup converter.py
b58844f
@pietermarsman
Rename klass to cls if it is the class variable, to be more consisten…
2e3ae75 
…t with standard practice
@pietermarsman
Cleanup cmap.py
c704b2a
@pietermarsman
Cleanup pdfdevice.py
7d9604c
@pietermarsman
flake8 ignore fontmetrics.py
8bf5e79
@pietermarsman
Cleanup test_pdfminer_psparser.py
6776ebc
@pietermarsman
Fix flake8 in pdfdocument.py; 339 errors to go
a96c44b
@pietermarsman
Fix flake8 utils.py; 326 errors togo
deb5494
@fakabbir @pietermarsman
pep8 correction for few files in /tools/ 328 > 160 to go (#342)
a416814 
* pep8 correction for few files in /tools/ 328 > 160 to go

* pep8 correction: 160 > 5 to go
@pietermarsman
Fix ascii85.py errors
09aabe9
@pietermarsman
Fix error in getting index from target that does not exists
8174b1b
@pietermarsman
Remove commented print lines
e7bc9da
@pietermarsman
Fix flake8 error in pdfinterp.py
c94f5fe
@pietermarsman
Fix python2 specific error by removing argument from print statement
c9101ad
@pietermarsman
Ignore invalid python2 syntax
ed6c439
@pietermarsman pietermarsman changed the title Pep8 Enforce pep8 coding style Dec 29, 2019
@pietermarsman pietermarsman merged commit f3ab1bc into develop Dec 29, 2019
@pietermarsman
Copy link
Member Author

@fakabbir, i've merged our work on coding style! Thanks for all the effort!

@pietermarsman pietermarsman mentioned this pull request Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use code-style enforcement
2 participants
@pietermarsman @fakabbir