Fix regression in page layout that sometimes returned text lines out of order #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pietermarsman @mikkkee take a look, please. |
jstockwin
requested changes
Aug 18, 2021
|
The py36 build failure here is definitely not the fault of this PR. Comparing https://github.com/pdfminer/pdfminer.six/runs/3846904701 (successful build) and https://github.com/pdfminer/pdfminer.six/pull/659/checks?check_run_id=3847247616 (unsuccessful build) there seem to be different versions of Python 3.6 and pip being fetched, which in turn causes cryptography to try to build Rust code. |
pietermarsman
approved these changes
Jan 26, 2022
|
Thanks again! |
Beants
added a commit
to HiTalentAlgorithms/pdfminer.six
that referenced
this pull request
Feb 14, 2022
* develop: Check blackness in github actions (pdfminer#711) Changed `log.info` to `log.debug` in six files (pdfminer#690) Update README.md batch for Continuous integration Update actions.yml so that it will run for all PR's Update development tools: travis ci to github actions, tox to nox, nose to pytest (pdfminer#704) Added feature: page labels (pdfminer#680) Remove obsolete returns (pdfminer#707) Revert "Remove obsolete returns" Remove obsolete returns Only use xref fallback if `PDFNoValidXRef` is raised and `fallback` is True (pdfminer#684) Use logger.warn instead of warnings.warn if warning cannot be prevented by user (pdfminer#673) Change log.info into log.debug to make pdfinterp.py less verbose Fix regression in page layout that sometimes returned text lines out of order (pdfminer#659) export type annotations in package (pdfminer#679) fix typos in PR template (pdfminer#681) pdf2txt: clean up construction of LAParams from arguments (pdfminer#682) Fixes jbig2 writer to write valid jb2 files Add support for JPEG2000 image encoding Added test case for CCITTFaxDecoder (pdfminer#700) Attempt to handle decompression error on some broken PDF files (pdfminer#637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #658: a regression in text line layout (LTLayoutContainer.group_textboxes) that caused it to merge lines of text into text boxes out of order, by merging two lines as adjacent elements even when there was a third line in between the two.
PR #315 changed the first element of each distance tuple from an int 0 or 1, where 0 was used for initial entries and 1 for subsequently-added groups, to a bool
is_firstwhere True was used for initial entries. This change broke the desired sort order, because 0 < 1 but True > False, and that was fixed by the followup commit 2bee7d8 inverting the meaning of the bool, but that commit missed adding anotwhere the bool (now correctly calledskip_isany) was used in an if expression. The fix is just to add thatnot.