Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update development tools: travis ci to github actions, tox to nox, nose to pytest #704

Merged
merged 19 commits into from
Feb 2, 2022

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented Jan 29, 2022

Pull request

Change the tools that we are using:

  • Travis CI -> Github Actions (No recurring free compute)
  • Tox -> Nox (More flexible, using python files to configure everything)
  • Nose -> pytest (Noxe is not actively developped anymore)

Fix #498

How Has This Been Tested?

The CI pipeline is running again :)

Checklist

  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial
    version
  • I have updated the README.md or verified that this
    is not necessary
  • I have updated the readthedocs documentation or
    verified that this is not necessary
  • I have added a concise human-readable description of the change to
    CHANGELOG.md

@pietermarsman pietermarsman changed the title Update tools Update development tools: travis ci to github actions, tox to nox, nose to pytest Jan 29, 2022
Copy link
Member

@jstockwin jstockwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks nice! Good to have things upgraded.

Just a few small suggested changes, mostly typos.

In addition, this PR now has conflicts.

It may also be worth protecting the develop branch and requiring all of these actions to pass before merge. Don't do this until right before you merge this PR, though, as it'll block all others.

.github/workflows/actions.yml Outdated Show resolved Hide resolved
.github/workflows/actions.yml Outdated Show resolved Hide resolved
.github/workflows/actions.yml Outdated Show resolved Hide resolved
.github/workflows/actions.yml Outdated Show resolved Hide resolved
pietermarsman and others added 2 commits February 2, 2022 21:39
Co-authored-by: Jake Stockwin <jstockwin@gmail.com>
@pietermarsman
Copy link
Member Author

@jstockwin thanks!

@pietermarsman pietermarsman enabled auto-merge (squash) February 2, 2022 21:14
@pietermarsman pietermarsman dismissed jstockwin’s stale review February 2, 2022 21:24

Fixed all requested changes

@pietermarsman pietermarsman merged commit b84cfc9 into develop Feb 2, 2022
@pietermarsman pietermarsman deleted the update-tools branch February 2, 2022 21:24
Beants added a commit to HiTalentAlgorithms/pdfminer.six that referenced this pull request Feb 14, 2022
* develop:
  Check blackness in github actions (pdfminer#711)
  Changed `log.info` to  `log.debug` in six files (pdfminer#690)
  Update README.md batch for Continuous integration
  Update actions.yml so that it will run for all PR's
  Update development tools: travis ci to github actions, tox to nox, nose to pytest (pdfminer#704)
  Added feature: page labels (pdfminer#680)
  Remove obsolete returns (pdfminer#707)
  Revert "Remove obsolete returns"
  Remove obsolete returns
  Only use xref fallback if `PDFNoValidXRef` is raised and `fallback` is True (pdfminer#684)
  Use logger.warn instead of warnings.warn if warning cannot be prevented by user (pdfminer#673)
  Change log.info into log.debug to make pdfinterp.py less verbose
  Fix regression in page layout that sometimes returned text lines out of order (pdfminer#659)
  export type annotations in package (pdfminer#679)
  fix typos in PR template (pdfminer#681)
  pdf2txt: clean up construction of LAParams from arguments (pdfminer#682)
  Fixes jbig2 writer to write valid jb2 files
  Add support for JPEG2000 image encoding
  Added test case for CCITTFaxDecoder (pdfminer#700)
  Attempt to handle decompression error on some broken PDF files (pdfminer#637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using nose for testing
2 participants