Remove upper version bounds #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an upper bound for dependency versions on a library is a source of troubles for users. Let's not do it as it makes pdfminer wreck havoc downstream. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
Thanks for noticing and fixing this issue @pombredanne! And @henryiii, thanks for writing the excellent article on why version caps in libraries are bad! |
7 tasks
|
Is there a timeline for releasing a version on PyPi (later than |
pietermarsman
added a commit
that referenced
this pull request
May 24, 2022
|
Publishing now |
Beants
added a commit
to HiTalentAlgorithms/pdfminer.six
that referenced
this pull request
Aug 5, 2022
* commit '8f52578e85b27831ab8a68a6d86721ea3348a553': Run black locally with nox (pdfminer#776) Install typing_extensions on Python 3.6 and 3.7 (pdfminer#775) Fix `TypeError` by Ignoring null characters in PSBaseParser (pdfminer#768) Fix `ValueError` with unencrypted metadata values (Fixes pdfminer#766). (pdfminer#774) Fix `TypeError` when getting default width of font (pdfminer#772) Deprecate usage of `if __name__ == "__main__"` in scripts that are not documented. Also deprecate usage of scripts that are only there for testing purposes. (pdfminer#756) Fix Sphinx warnings and error (pdfminer#760) Update CHANGELOG.md for pdfminer#755 Remove upper version bounds (pdfminer#755) Ignore path constructors that do not begin with m (pdfminer#749) Bump version 20220506 & fix small issue with types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an upper bound for dependency versions on a library is a source of troubles for users.
Let's not do it as it makes pdfminer wreck havoc downstream.
@pietermarsman you introduced this in this recent commit 1bf3c42#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R20
Because of this change, I cannot upgrade to the latest pdfminer short of downgrading cryptography which is a security risk and not an issue for pdfminer proper.
For a longer and comprehensive exploration of the issue, please read this excellent article https://iscinumpy.dev/post/bound-version-constraints/ by @henryiii
Signed-off-by: Philippe Ombredanne pombredanne@nexb.com
Pull request
Please remove this paragraph and replace it with a description of your PR.
Also include links to the issues that it fixes.
How Has This Been Tested?
Please repalce this paragraph with a description of how this PR has been
tested. Include the necessary instructions and files such that other can
reproduce it.
Checklist
works
version
is not necessary
verified that this is not necessary
CHANGELOG.md