Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install typing_extensions on Python 3.6 and 3.7 #775

Merged
merged 4 commits into from
Jun 26, 2022
Merged

Install typing_extensions on Python 3.6 and 3.7 #775

merged 4 commits into from
Jun 26, 2022

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented Jun 26, 2022 •
edited
Loading

Pull request

Fix #762

How Has This Been Tested?

Used Python 3.6 and ran python setup.py install and checked if typing-extensions was installed. It was! :)

Checklist

  • I have formatted my code with black.
  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial
    version
  • I have updated the README.md or verified that this
    is not necessary
  • I have updated the readthedocs documentation or
    verified that this is not necessary
  • I have added a concise human-readable description of the change to
    CHANGELOG.md

@pietermarsman pietermarsman merged commit 4733eb3 into master Jun 26, 2022
@pietermarsman pietermarsman deleted the 762-install-typing-extensions-on-python36 branch June 26, 2022 15:47
Beants added a commit to HiTalentAlgorithms/pdfminer.six that referenced this pull request Aug 5, 2022
@Beants
Merge commit '8f52578e85b27831ab8a68a6d86721ea3348a553' into develop
7c7568c 
* commit '8f52578e85b27831ab8a68a6d86721ea3348a553':
  Run black locally with nox (pdfminer#776)
  Install typing_extensions on Python 3.6 and 3.7 (pdfminer#775)
  Fix `TypeError` by Ignoring null characters in PSBaseParser (pdfminer#768)
  Fix `ValueError` with unencrypted metadata values (Fixes pdfminer#766). (pdfminer#774)
  Fix `TypeError` when getting default width of font (pdfminer#772)
  Deprecate usage of `if __name__ == "__main__"` in scripts that are not documented. Also deprecate usage of scripts that are only there for testing purposes. (pdfminer#756)
  Fix Sphinx warnings and error (pdfminer#760)
  Update CHANGELOG.md for pdfminer#755
  Remove upper version bounds (pdfminer#755)
  Ignore path constructors that do not begin with  m (pdfminer#749)
  Bump version 20220506 & fix small issue with types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency (typing_extensions) requires python 3.7, pdfminer is said to require python 3.6
1 participant
@pietermarsman