Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockStream blocks on large output #287

Closed
hildjj opened this issue Jun 10, 2022 · 0 comments · Fixed by #288
Closed

MockStream blocks on large output #287

hildjj opened this issue Jun 10, 2022 · 0 comments · Fixed by #288
Assignees
@hildjj
Labels
bug Something isn't working

Comments

@hildjj
Copy link
Contributor

hildjj commented Jun 10, 2022

In run.spec.ts if the output of an exec call is more than 16KB, the write blocks, due to the highwaterMark of the MockStream.
@hildjj hildjj added the bug Something isn't working label Jun 10, 2022
@hildjj hildjj self-assigned this Jun 10, 2022
@hildjj hildjj mentioned this issue Jun 10, 2022
Merged
hildjj added a commit to hildjj/peggy that referenced this issue Jun 10, 2022
@hildjj
Handle large outputs from exec. Fixes peggyjs#287.
a8f96d9
@hildjj hildjj mentioned this issue Jun 10, 2022
Merged
hildjj added a commit to hildjj/peggy that referenced this issue Jun 10, 2022
@hildjj
Handle large outputs from exec. Fixes peggyjs#287.
766c6a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hildjj hildjj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle large outputs from exec. hildjj/peggy
1 participant
@hildjj