Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug helpers - new output type ast / CLI option -a/--ast #206

Merged
merged 4 commits into from
Jun 11, 2022

Conversation

Mingun
Copy link
Member

@Mingun Mingun commented Oct 27, 2021

Working on my next PR I realized that I need a way to get the AST generated, so I've added a new output type ast. It also can be useful for plugin writers to check how their plugin changes AST.

@hildjj
Copy link
Contributor

hildjj commented Oct 27, 2021

A couple of things:

  • Yes, I want this feature.
  • What do you think about making it be --format json instead?
  • What about --format bytecode as well? It could output bytecode + comments as text or binary, I suppose.
  • I'm doing a big refactor of the CLI right now for Refactor CLI to use Jest for coverage #205, so wait until that lands, please?

@hildjj hildjj mentioned this pull request Nov 23, 2021
15 tasks
@hildjj
Copy link
Contributor

hildjj commented May 22, 2022

Would you like to land this before or after I update dependencies?

@Mingun
Copy link
Member Author

Mingun commented May 23, 2022

I think, after. I need some time to upgrade this, it may not be soon

@hildjj hildjj deleted the branch peggyjs:main May 28, 2022 17:07
@hildjj hildjj closed this May 28, 2022
@hildjj hildjj reopened this Jun 1, 2022
@Mingun Mingun changed the base branch from 1.3 to main June 1, 2022 16:57
bin/peggy-cli.js Show resolved Hide resolved
test/cli/run.spec.ts Outdated Show resolved Hide resolved
@Mingun Mingun force-pushed the debug-helpers branch 2 times, most recently from e50c220 to 5bbdf1b Compare June 10, 2022 19:58
bin/peggy-cli.js Outdated Show resolved Hide resolved
docs/documentation.html Outdated Show resolved Hide resolved
docs/documentation.html Outdated Show resolved Hide resolved
docs/documentation.html Outdated Show resolved Hide resolved
test/cli/run.spec.ts Outdated Show resolved Hide resolved
@Mingun
Copy link
Member Author

Mingun commented Jun 11, 2022

Now it is ready for final review

@hildjj hildjj merged commit 48585a5 into peggyjs:main Jun 11, 2022
@Mingun Mingun deleted the debug-helpers branch June 11, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants