Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0 #221

Closed
14 of 15 tasks
hildjj opened this issue Nov 23, 2021 · 15 comments
Closed
14 of 15 tasks

Release 2.0 #221

hildjj opened this issue Nov 23, 2021 · 15 comments

Comments

@hildjj
Copy link
Contributor

hildjj commented Nov 23, 2021

TODO list:

Everything else that isn't a show-stopper will be pushed to 2.1, including:

@hildjj
Copy link
Contributor Author

hildjj commented May 24, 2022

Note: because of issues arising in #248, this is going to be a 2.0 release. Same TODO list.

@hildjj hildjj changed the title Release 1.3 Release 2.0 May 24, 2022
@physikerwelt
Copy link

@hildjj in #244 (comment) you estimated an upper bound for the release date as June 9th. Is this correct? Would it be feasible to update the estimate here if new information is available?

@hildjj
Copy link
Contributor Author

hildjj commented May 26, 2022

Keep in mind that the estimate was just an estimate, not a contract. If you'd like to help, here are a few things that will get us there more quickly:

@physikerwelt
Copy link

physikerwelt commented May 26, 2022

Thank you. I think I am not familiar enough with the code to be a great help here.

Check all of the PRs since 1.2 to make sure they are adequately reflected in the release notes

At least this is definitely not the case, but I do not understand enough to make a reasonable pull request, sorry.

physikerwelt added a commit to physikerwelt/phpeggy that referenced this issue May 26, 2022
physikerwelt added a commit to physikerwelt/phpeggy that referenced this issue May 26, 2022
@hildjj
Copy link
Contributor Author

hildjj commented May 27, 2022

I think we should push #206 to the next release. That leaves reviews needed for #251 and #252, then release engineering.

@hildjj
Copy link
Contributor Author

hildjj commented May 28, 2022

This release should go out within the hour. Final release engineering in progress.

@hildjj
Copy link
Contributor Author

hildjj commented May 28, 2022

Leaving this open in case there are nits. For example, I didn't add the date to the changelog. :(

@physikerwelt
Copy link

Thank you @hildjj . I did run the upgrade and realized that there are a few duplicated rules. In my case, there were 151 functions before and now there are 203. Sometimes the exact same functions follow each other. Eventually, all tests still pass so this might only be a cosmetic issue, but it would feel good to understand this change.

@hildjj
Copy link
Contributor Author

hildjj commented May 28, 2022

Can you point out the line numbers of a couple of the dups please? I bet you have them right in front of you, and that way I won't have to go through the whole diff.

@physikerwelt
Copy link

The link should point to the first difference. Unfortunately, the diff viewer can not handle whitespace so well. That is how it looks in my Firefox:

image

@hildjj
Copy link
Contributor Author

hildjj commented May 28, 2022

Let's start a new issue for this, I think? We'll need to do some analysis and brainstorming of solutions.

@physikerwelt
Copy link

physikerwelt commented May 28, 2022

Ok, will do. I was hoping for another answer;-)

@hildjj
Copy link
Contributor Author

hildjj commented May 28, 2022

@Mingun might just be able to tell by looking at it. :)

@Mingun
Copy link
Member

Mingun commented May 28, 2022

This is because now we can generate a source map and should map each function to a different location in the source .peggy

@hildjj
Copy link
Contributor Author

hildjj commented May 31, 2022

If anyone has more issues with the release, take them to #268, please.

@hildjj hildjj closed this as completed May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants