-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcemap url #218
Sourcemap url #218
Conversation
63c0012
to
55e0247
Compare
Easiest way to look at this is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with keeping in mind #215 feedback and small fixes in the documentation here
docs/documentation.html
Outdated
<dt><code>-m</code>, <code>--source-map <file></code></dt> | ||
<dd>Generate a source map. If name is not specified, the source map will be | ||
named "<input_file>.map" if input is a file and "source.map" if input is a | ||
standard input. If the special filename 'inline' is given, the sourcemap | ||
will be embedded in the output file as a data URI. If the filename is | ||
prefixed with `hidden:`, no mapping URL will be included so that the mapping | ||
can be specified with an HTTP SourceMap: header. This option conflicts with | ||
the `-t/--test` and `-T/--test-file` options unless `-o/--output` is also | ||
specified</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor formatting fix:
<dt><code>-m</code>, <code>--source-map <file></code></dt> | |
<dd>Generate a source map. If name is not specified, the source map will be | |
named "<input_file>.map" if input is a file and "source.map" if input is a | |
standard input. If the special filename 'inline' is given, the sourcemap | |
will be embedded in the output file as a data URI. If the filename is | |
prefixed with `hidden:`, no mapping URL will be included so that the mapping | |
can be specified with an HTTP SourceMap: header. This option conflicts with | |
the `-t/--test` and `-T/--test-file` options unless `-o/--output` is also | |
specified</dd> | |
<dt><code>-m</code>, <code>--source-map <file></code></dt> | |
<dd>Generate a source map. If name is not specified, the source map will be | |
named "<input_file>.map" if input is a file and "source.map" if input is a | |
standard input. If the special filename <code>inline</code> is given, the sourcemap | |
will be embedded in the output file as a data URI. If the filename is | |
prefixed with <code>hidden:</code>, no mapping URL will be included so that the mapping | |
can be specified with an HTTP SourceMap: header. This option conflicts with | |
the <code>-t/--test</code> and <code>-T/--test-file</code> options unless <code>-o/--output</code> is also | |
specified</dd> |
…le, or inlining it if requested.
Rebased, and included your change above. @Mingun could you take a quick look at this before I land it, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All ok now
Add
//# sourceMappingURL=
to generated JS files from the CLI only. Use the magic filenameinline
to get an inline sourceMap, like rollup does.For the infrequent use case when people want to use an HTTP
SourceMap:
header, prefix the output file withhidden:
.