Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #248

Merged
merged 5 commits into from
May 26, 2022
Merged

Update deps #248

merged 5 commits into from
May 26, 2022

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented May 22, 2022

Issues fixed:

  • Jest thinks the sourcemap URL writing code is a sourcemap for the target file. Symptom: "Test suite failed to run at invariant"
  • Update to commander added the error method, as requested. No longer need to use internal API.
  • Ensured that run.spec.ts more-or-less passes conversion to JS with tsc
  • On node 18, SourceMapConsumer was failing because fetch now exists. Updated to latest beta of source-map to get around this issue

@hildjj hildjj mentioned this pull request May 22, 2022
15 tasks
@hildjj
Copy link
Contributor Author

hildjj commented May 22, 2022

And of course the latest Jest doesn't support node 10 anymore. I can either go back to a working version, or we can deprecate node 10. Opinions?

@hildjj
Copy link
Contributor Author

hildjj commented May 22, 2022

Trying to back down to jest 27.5.1 isn't working terribly well. There are still several other deps that don't support node 10 anymore.

I think it may be time to drop node 10 support. Should we do a major version change for that?

@smcjones
Copy link

Not a regular contributor here, but voting to add a major version change for deprecation. It'll be easier to track the nest of node dependencies.

@hildjj
Copy link
Contributor Author

hildjj commented May 23, 2022

@smcjones 's argument is persuasive. If we do cut this as a 2.0 release, I think I'll want to be more aggressive about #223, moving to a more-normal dependency relationship instead of bundling.

@Mingun
Copy link
Member

Mingun commented May 24, 2022

It seems that according to semver dropping support of old environment should be a breaking change that requires major version bump. Relevant discussion: semver/semver#317

@hildjj hildjj merged commit 5a25b79 into peggyjs:1.3 May 26, 2022
@hildjj hildjj deleted the update-deps branch May 26, 2022 19:55
@hildjj hildjj mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants