Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot v0.9.42 #18

Merged
merged 13 commits into from
May 30, 2024
Merged

Polkadot v0.9.42 #18

merged 13 commits into from
May 30, 2024

Conversation

gianfra-t
Copy link

We want master to track always the latest branch used.

@TorstenStueber
Copy link

TorstenStueber commented May 29, 2024

The whole code in the /node and /runtime folders does not actually matter, correct? Maybe it's best to just remove it in order to save maintenance overhead and avoid confusion (this can happen in a new PR of course).

@ebma
Copy link
Member

ebma commented May 30, 2024

The whole code in the /node and /runtime folders does not actually matter, correct?

True, removing it is a great idea. Let's do that. Can you please create the follow-up ticket for this @gianfra-t?

@gianfra-t
Copy link
Author

We can remove it as part of this, or at least before it since it doesn't make sense to update code that is not used. Are we sure we don't use it for benchmarking the pallet?

@gianfra-t gianfra-t merged commit f9ffb13 into master May 30, 2024
@TorstenStueber
Copy link

I am fine with removing it in the PR for the upgrade to 1.1.0.

But important part about the benchmarking: please check whether the code would still be required for benchmarking. Maybe it is possible to do it via the Pendulum repository instead...

@gianfra-t
Copy link
Author

I believe we should do it in the pendulum repo, like we did with this change for the Spacewalk pallets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants