Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

178 add benchmarks for custom pallets per runtime #453

Merged
merged 36 commits into from
Jun 10, 2024

Conversation

bogdanS98
Copy link
Contributor

@bogdanS98 bogdanS98 commented Apr 16, 2024

Closes #178.

@bogdanS98 bogdanS98 linked an issue Apr 16, 2024 that may be closed by this pull request
3 tasks
@ebma
Copy link
Member

ebma commented Apr 17, 2024

Note:

  • parachain-staking and issue pallets benchmarks are not yet included in any runtime.
  • nomination , redeem , replace, vault-registry pallets benchmarks are not yet included in Pendulum runtime.

Should we just add them then or is there a good reason not to?

Please ensure that the collator nodes are redeployed after this PR is merged.

What changes require the redeployment of the collator nodes?

@bogdanS98
Copy link
Contributor Author

Should we just add them then or is there a good reason not to?

Yes, we should add them. They're not added yet because I'm still getting some errors on some benchmarks and I'm trying to fix them.
Meanwhile everything that's already added in the PR can be reviewed as it's independent of the missing pallets.

What changes require the redeployment of the collator nodes?

I modified Cargo.toml and chain_spec.rs files from the node directory; updated Spacewalk pallets versions and some minor changes in the genesis configs.

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far 👍

runtime/foucoco/src/lib.rs Show resolved Hide resolved
runtime/pendulum/src/lib.rs Show resolved Hide resolved
node/src/chain_spec.rs Show resolved Hide resolved
runtime/amplitude/Cargo.toml Outdated Show resolved Hide resolved
runtime/amplitude/src/lib.rs Show resolved Hide resolved
@ebma
Copy link
Member

ebma commented May 3, 2024

Is this now ready for a re-review or are you still adding more changes to it?

@bogdanS98
Copy link
Contributor Author

Is this now ready for a re-review or are you still adding more changes to it?

Still adding changes

…o 178-add-benchmarks-for-custom-pallets-per-runtime
@gianfra-t gianfra-t mentioned this pull request May 14, 2024
@ebma
Copy link
Member

ebma commented May 31, 2024

@bogdanS98 what's the status with this? Do you need help here?

@vadaynujra
Copy link

Any actions for us to take wrt the node upgrades @ebma ?

@ebma
Copy link
Member

ebma commented Jun 4, 2024

Good question @vadaynujra. @bogdanS98 in the description you mention that the nodes need to be redeployed. Looking at the PR, there are some changes to files in the node folder. However, to me it seems like these changes don't really require a redeployment. Changing the chain spec does not affect the operation of the nodes. What do you think?

@bogdanS98
Copy link
Contributor Author

@ebma Indeed changing the chain spec does not affect the operation of the nodes, I'll update the description 👍🏼

@ebma ebma force-pushed the 178-add-benchmarks-for-custom-pallets-per-runtime branch from 9c61153 to 9a5307b Compare June 4, 2024 15:02
README.md Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
pallets/parachain-staking/src/benchmarking.rs Show resolved Hide resolved
runtime/amplitude/src/lib.rs Outdated Show resolved Hide resolved
runtime/foucoco/src/lib.rs Outdated Show resolved Hide resolved
bogdanS98 and others added 4 commits June 10, 2024 13:21
Co-authored-by: Marcel Ebert <mail@marcel-ebert.de>
Co-authored-by: Marcel Ebert <mail@marcel-ebert.de>
Co-authored-by: Marcel Ebert <mail@marcel-ebert.de>
@bogdanS98 bogdanS98 requested a review from ebma June 10, 2024 11:32
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdanS98 bogdanS98 merged commit 3835d27 into main Jun 10, 2024
3 checks passed
@bogdanS98 bogdanS98 deleted the 178-add-benchmarks-for-custom-pallets-per-runtime branch June 10, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmarks for custom pallets per runtime
3 participants