-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
178 add benchmarks for custom pallets per runtime #453
178 add benchmarks for custom pallets per runtime #453
Conversation
Should we just add them then or is there a good reason not to?
What changes require the redeployment of the collator nodes? |
Yes, we should add them. They're not added yet because I'm still getting some errors on some benchmarks and I'm trying to fix them.
I modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far 👍
Is this now ready for a re-review or are you still adding more changes to it? |
Still adding changes |
…o 178-add-benchmarks-for-custom-pallets-per-runtime
…o 178-add-benchmarks-for-custom-pallets-per-runtime
@bogdanS98 what's the status with this? Do you need help here? |
Any actions for us to take wrt the node upgrades @ebma ? |
Good question @vadaynujra. @bogdanS98 in the description you mention that the nodes need to be redeployed. Looking at the PR, there are some changes to files in the node folder. However, to me it seems like these changes don't really require a redeployment. Changing the chain spec does not affect the operation of the nodes. What do you think? |
@ebma Indeed changing the chain spec does not affect the operation of the nodes, I'll update the description 👍🏼 |
9c61153
to
9a5307b
Compare
…ttps://github.com/pendulum-chain/pendulum into 178-add-benchmarks-for-custom-pallets-per-runtime
Co-authored-by: Marcel Ebert <mail@marcel-ebert.de>
Co-authored-by: Marcel Ebert <mail@marcel-ebert.de>
Co-authored-by: Marcel Ebert <mail@marcel-ebert.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #178.