proto: align proto packages to rust crates #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Failure
|
A follow-on step once this PR lands (which we should do as soon as the Rust code compiles again) is to split up the RPC definitions in the |
VSCode Search&Replace core::crypto::v1alpha1 to penumbra::crypto::tct::v1alpha1 files to include crates/crypto/tct
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Failure
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Failure
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Error
hdevalence
force-pushed
the
reorg-protos
branch
from
85a0adb to
b961f72
Compare
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
It was easier than I expected to patch up the import paths; we'll still need to go through and fix up the |
|
It looks like |
This was referenced Sep 22, 2023
34 tasks
|
Refs #2288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reorganizing the Rust crates into a coherent heirarchy, we never did the same for the .proto files. This PR does that.
Currently, this just reorganizes the proto files, updates the
proto-compilertool, and regenerates the source code. What's remaining is to update all of the import paths in all of the domain type implementations that reference the proto structures. I'd suggest we swarm that part tomorrow morning, using live share + search&replace, since this PR will conflict with everything else (and break all of the protos used by other tooling like the web interfaces).I don't think we should try to update all of the
TYPE_URLs at this point; those are used for genericAnysupport, which we don't usually make use of, and landing the changes ASAP is more important than restoring that functionality (except where we know we need it because eg the smoke test fails).