-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix asset metadata for fee estimation #1468
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Visit the preview URL for this PR (updated for commit ec51e8b): https://penumbra-ui-preview--pr1468-fee-estimate-denom-n094myqk.web.app (expires Wed, 24 Jul 2024 04:48:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
requesting additional reviews for assurance after the remote registry work was merged |
references #1459
currently, the fee estimation in minifront is hardcoded to use the staking token. Instead, we reconstruct the metadata from the
assetId
to display the proper token asset. cc @vacekjIf the user has UM, the will display the native staking token asset
If the user doesn't have UM (simulated by setting the
gasFeeToken
toextractAltFee
in the transaction planner service implementation), it will reconstruct the alternative fee metadata from the assetId.Currently, the estimated fee is displaying zero since the gas prices are set to zero for that assetId.
If gas prices aren't set for a particular assetId, it will error with "
GasPrices not available
"