Update all non-crate deps #841
Conversation
| @@ -87,7 +87,7 @@ const postRequest = () => { | |||
| window.origin, | |||
| ); | |||
| request.promise | |||
| .catch(e => connection.reject(e)) | |||
| .catch((e: unknown) => connection.reject(e)) | |||
There was a problem hiding this comment.
New eslint rule: https://typescript-eslint.io/rules/use-unknown-in-catch-callback-variable/
Catch needs to specify that it's an unknown
| "humanize-duration": "^3.31.0", | ||
| "lucide-react": "^0.354.0", | ||
| "lucide-react": "^0.363.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-json-view-lite": "^1.3.0", | ||
| "react-loader-spinner": "^6.1.6", | ||
| "react-router-dom": "^6.22.3", | ||
| "sonner": "1.4.3", |
There was a problem hiding this comment.
Sonner has an update, but the latest version has a bug: emilkowalski/sonner#378. We need to wait a bit one this one.
| @@ -11,7 +11,7 @@ import { createChannelTransport } from '@penumbra-zone/transport-dom/src/create' | |||
| import { PenumbraSymbol } from './global'; | |||
| import { jsonOptions } from '@penumbra-zone/types/src/registry'; | |||
|
|
|||
| const prax_id = 'lkpmkhpnhknhmibgnmmhdhgdilepfghe' as const; | |||
| const prax_id = 'lkpmkhpnhknhmibgnmmhdhgdilepfghe'; | |||
There was a problem hiding this comment.
Eslint rule that is was an unnecessary const
| @@ -59,6 +59,7 @@ module.exports = { | |||
| ], | |||
| }, | |||
| ], | |||
| '@typescript-eslint/restrict-template-expressions': ['error', { allowNumber: true }], | |||
There was a problem hiding this comment.
New eslint rule: https://typescript-eslint.io/rules/restrict-template-expressions/
I think this makes sense for everything except for numbers. I think we all know that putting a number into a string template stringifies it and there isn't any crazy things like [object Object] to worry about.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "$schema": "https://turbo.build/schema.json", | |||
| "globalDependencies": ["**/.env.*local"], | |||
| "globalEnv": ["NODE_ENV"], | |||
| "globalEnv": ["NODE_ENV", "MODE"], | |||
There was a problem hiding this comment.
New turbo eslint rule that requires us to put env variables here
|
LGTM |
A follow up to #839 in preparation for release