-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all non-crate deps #841
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ import { createChannelTransport } from '@penumbra-zone/transport-dom/src/create' | |
import { PenumbraSymbol } from './global'; | ||
import { jsonOptions } from '@penumbra-zone/types/src/registry'; | ||
|
||
const prax_id = 'lkpmkhpnhknhmibgnmmhdhgdilepfghe' as const; | ||
const prax_id = 'lkpmkhpnhknhmibgnmmhdhgdilepfghe'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Eslint rule that is was an unnecessary const |
||
const prax_origin = `chrome-extension://${prax_id}`; | ||
const prax_manifest = `chrome-extension://${prax_id}/manifest.json`; | ||
|
||
|
@@ -30,7 +30,7 @@ export const requestPraxConnection = async () => { | |
if (window[PenumbraSymbol]?.[prax_origin]?.manifest !== prax_manifest) { | ||
throw new PraxManifestError('Incorrect Prax manifest href'); | ||
} | ||
return window[PenumbraSymbol][prax_origin]?.request(); | ||
return window[PenumbraSymbol][prax_origin].request(); | ||
}; | ||
|
||
export const isPraxConnected = () => Boolean(window[PenumbraSymbol]?.[prax_origin]?.isConnected()); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,7 @@ module.exports = { | |
], | ||
}, | ||
], | ||
'@typescript-eslint/restrict-template-expressions': ['error', { allowNumber: true }], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New eslint rule: https://typescript-eslint.io/rules/restrict-template-expressions/ I think this makes sense for everything except for numbers. I think we all know that putting a number into a string template stringifies it and there isn't any crazy things like |
||
}, | ||
overrides: [ | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New eslint rule: https://typescript-eslint.io/rules/use-unknown-in-catch-callback-variable/
Catch needs to specify that it's an unknown