Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support assume role #70

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Conversation

yonahd
Copy link

@yonahd yonahd commented Nov 15, 2021

This feature allows users to choose to use assume role to give the exporter access

@yonahd
Copy link
Author

yonahd commented Nov 17, 2021

Can someone review?

@denisok denisok requested review from a team, percona-csalguero and JiriCtvrtka and removed request for a team November 24, 2021 12:06
@denisok
Copy link

denisok commented Nov 24, 2021

@yonahd , yep sorry for the delay

sessions/sessions.go Outdated Show resolved Hide resolved
@yonahd
Copy link
Author

yonahd commented Nov 30, 2021

Looks like the tests are failing because of
Error: AWS_ACCESS_KEY and AWS_SECRET_KEY environment variables must be set for this test

@denisok denisok added the award swag prize for the contributors. Please contact Percona if we can't reach you! label Dec 1, 2021
@denisok denisok merged commit e9c35fd into percona:main Dec 1, 2021
@yonahd yonahd deleted the feature/assume_role_branch branch December 3, 2021 08:10
@Aleksa-del
Copy link

@yonahd Hello! We would love to send you a gift from Percona for your contribution. Please, contact us at community-team@percona.com

@maxknee
Copy link

maxknee commented Dec 3, 2021

Saw this is merged - when is this going to be released?

@denisok
Copy link

denisok commented Dec 4, 2021

@maxknee lets continue conversation in #71 this one is closed.

@denisok denisok added this to the 0.7.2 milestone Dec 14, 2021
mprokopov pushed a commit to ozean12/rds_exporter that referenced this pull request Jul 9, 2024
* assume role

* move credentials into session
mprokopov added a commit to ozean12/rds_exporter that referenced this pull request Jul 9, 2024
* Create rds_exporter-component.yaml

* PMM-6120 Use go 1.14 (percona#45)

* PMM-6213 Remove go 1.13 from travis. (percona#46)

* PMM-6213 Remove go 1.13 from travis.

* PMM-6213 Add go 1.15.x

* PMM-6213 Add go tip.

* PMM-6756 Added go 1.15.x. (percona#48)

* [PMM-6756] Added go 1.15.x.

* PMM-6756 Update

* PMM-6756 Update

* PMM-6756 Revert

* Dummy

* PMM-6756 Update golden files

Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>

* Overcome the limitation of 100 dbinstances (percona#47)

* ci: rotate integration keys (percona#52)

* Delete .travis.yml

* PMM-7602 Add GitHub Action (percona#53)

* PMM-7602 Add GitHub Action

* PMM-7602 Point actions to forked repo.

* PMM-7602 Removed travis.

* PMM-7602 Use go modules.

* PMM-7602 Fix check.

* PMM-7602 Fix mod.

* PMM-7602 Fix setup.

* PMM-7602 Fix setup.

* PMM-7602 Fix setup.

* add environment

* PMM-7602 Fix tests.

* PMM-7602 Fix codecov

* PMM-7602 defines what to use go get or go install

* PMM-7602 Improve go get/install

* PMM-7602 Improve get promu.

* PMM-7602 Use tools module for tooling.

* PMM-7602 Fix mods.

* PMM-7602 Fix path

* PMM-7602 Fix gocoverutil

Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>

* PPMM-7961 Updated exporter_shared (percona#59)

* PMM-7902 Remove Go 1.15 (percona#60)

* Add docker multistage build (percona#61)

* bring back maxInterval=60 sec (percona#63)

Co-authored-by: Volodymyr Linevych <vlin@hellofresh.com>
Co-authored-by: Volodymyr Linevych <4980689+vlinevych@users.noreply.github.com>

* PMM-8207 Cleanup. (percona#57)

Co-authored-by: Jiri Ctvrtka <jiri.ctvrtka.sde@gmail.com>

* add the ReplicaLag metric (percona#51)

* Update README.md (percona#65)

Remove mentioning upstream as we reworked the project entirely. This statement can confuse people

* PMM-6013 change default branch to main (percona#67)

* Support assume role (percona#70)

* assume role

* move credentials into session

* adding .goreleaser.yml (percona#72)

* adding .goreleaser.yml

Signed-off-by: Max Knee <Max_Knee@comcast.com>

* adding new line

Signed-off-by: Max Knee <Max_Knee@comcast.com>

* Apply suggestions from code review

Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>

* Update .goreleaser.yml

* adding releaser action

Signed-off-by: Max Knee <Max_Knee@comcast.com>

* Update release.yml

* Update .goreleaser.yml

* maxknee test docker build

Signed-off-by: Max Knee <Max_Knee@comcast.com>

* adding go 1.16

Signed-off-by: Max Knee <Max_Knee@comcast.com>

* debugging action

Signed-off-by: Max Knee <Max_Knee@comcast.com>

* updating dockerfile

Signed-off-by: Max Knee <Max_Knee@comcast.com>

* reverting docker file and adding new releaserfile

Signed-off-by: Max Knee <Max_Knee@comcast.com>

Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>

* Update Dockerfile.releaser

* Update .goreleaser.yml

* Update .goreleaser.yml

* Update release.yml

* Update release.yml

* cost exclaimer  (percona#73)

* cost exclaimer and docker push

* Update Makefile

Remove change of makefile

* PMM-9337 Update go 1.17 (percona#77)

* PMM-9337 Update go 1.17

* Fix codecov

Co-authored-by: JiriCtvrtka <62988319+JiriCtvrtka@users.noreply.github.com>

* Fix incorrect version (percona#76)

* Fix incorrect version.

* FIx for releaser itself.

* Removing promu.

* Delete another file related to promu.

* update ldflags

update ldflags to fill correct values for version

* Remove make build.

* Tidy.

* Revert "Tidy."

This reverts commit 472ca26.

* add prometheus again

* add required packages

* Remove make tarball from CI.

* Remove make tarball

* trigger

Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>

* PMM-11049 Typo present in enhanced metrics scraper for rds_exporter (percona#82)

Co-authored-by: cezmunsta <github@incoming-email.co.uk>

* PMM-11312 --version (percona#84)

* PMM-11312 --version

* PMM-11312 make feature-build

* PMM-11312 newline

* PMM-11312 rename command

* PMM-11312 just update version

* PMM-7 Add dependabot (percona#85)

* PMM-11497 Update dependencies. (percona#87)

* PMM-11632 rds_exporter ignores DisableEnhancedMetrics (percona#91)

* Discord link has been removed (percona#92)

* PMM-12339 remove go tip (percona#94)

* PMM-12339 remove go tip

PMM-12339

https://goreleaser.com/deprecations/?h=rm+dist#-rm-dist

* PMM-12339 refactor go workflow

* PMM-12339 Hix CI

* PMM-12339 avoid triggering tests twice

---------

Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>

* Rename build to builder

* golang 1.19

* Patch dist

---------

Co-authored-by: Eduardo Rodrigues Semensati <24209506+EduSemensati@users.noreply.github.com>
Co-authored-by: Andrii Skomorokhov <askomorokhov@users.noreply.github.com>
Co-authored-by: Jaroslav Musil <49949480+yareach@users.noreply.github.com>
Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Co-authored-by: Volodymyr Linevych <4980689+vlinevych@users.noreply.github.com>
Co-authored-by: Alex Tymchuk <alexander.tymchuk@percona.com>
Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>
Co-authored-by: Carlos Salguero <carlos.salguero@percona.com>
Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
Co-authored-by: Volodymyr Linevych <vlin@hellofresh.com>
Co-authored-by: Jiri Ctvrtka <jiri.ctvrtka.sde@gmail.com>
Co-authored-by: ben lovett <blovett@users.noreply.github.com>
Co-authored-by: Roma Novikov <roma.novikov@percona.com>
Co-authored-by: Nikita Beletskii <nikita.beletskii@percona.com>
Co-authored-by: Yonah Dissen <47282577+yonahd@users.noreply.github.com>
Co-authored-by: Max Knee <maxknee@gmail.com>
Co-authored-by: JiriCtvrtka <62988319+JiriCtvrtka@users.noreply.github.com>
Co-authored-by: cezmunsta <github@incoming-email.co.uk>
Co-authored-by: Yaroslav Podorvanov <63663261+YaroslavPodorvanov@users.noreply.github.com>
Co-authored-by: Artem Gavrilov <charlieblackwood7@gmail.com>
Co-authored-by: Przemyslaw Kadej <przemyslaw@kadej.org>
Co-authored-by: Daniil Bazhenov <mail@dbazhenov.ru>
Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
award swag prize for the contributors. Please contact Percona if we can't reach you! community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants