adding .goreleaser.yml #72

maxknee · 2021-12-08T16:09:53Z

Adding a .goreleaser.yml similarly found mongodb_exporter

This should close #71

Signed-off-by: Max Knee <Max_Knee@comcast.com>

it-percona-cla · 2021-12-08T16:09:58Z

All committers have signed the CLA.

denisok · 2021-12-08T16:12:40Z

@maxknee thanks for contribution! looks like you are missing the new line at the end of the file.

Also check this: percona/mongodb_exporter#392 probably would land soon.

Signed-off-by: Max Knee <Max_Knee@comcast.com>

maxknee · 2021-12-08T16:32:28Z

@maxknee thanks for contribution! looks like you are missing the new line at the end of the file.

Also check this: percona/mongodb_exporter#392 probably would land soon.

do we want to roll this in OR add it after this is merged? Happy to do either

denisok · 2021-12-08T16:49:11Z

@maxknee thanks for contribution! looks like you are missing the new line at the end of the file.
Also check this: percona/mongodb_exporter#392 probably would land soon.

do we want to roll this in OR add it after this is merged? Happy to do either

as you would like. just test that it works.

maxknee · 2021-12-08T16:50:37Z

Would prefer to merge, then work on releasing it as a package.
Need the aws_iam_role feature sooner

.goreleaser.yml

Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>

denisok · 2021-12-08T17:13:24Z

ok. could you please also add release action then?
https://github.com/percona/mongodb_exporter/blob/main/.github/workflows/release.yml

and please remove docker container as for now, as creating new project in docker hub would take some time and we didn't plan that yet.

or you can try to change it to push to github and lets see if it works: ghcr.io/ :

  image_templates:
  - "ghcr.io/percona/rds_exporter:{{.Major}}.{{.Minor}}"
  - "ghcr.io/percona/rds_exporter:{{.Version}}"

Signed-off-by: Max Knee <Max_Knee@comcast.com>

denisok · 2021-12-09T11:06:38Z

@maxknee have you tested it ?
https://github.com/percona/rds_exporter/blob/main/.promu.yml
looks like different tags
https://github.com/percona/rds_exporter/blob/main/.github/workflows/go.yml#L43

@percona-csalguero could you please check?

Add releaser

Signed-off-by: Max Knee <Max_Knee@comcast.com>

maxknee · 2021-12-09T17:00:26Z

looking into this.
I'm getting an error: https://github.com/maxknee/rds_exporter/runs/4473449016?check_suite_focus=true#step:4:198 but if i build locally it's fine. using the same container locally.

Signed-off-by: Max Knee <Max_Knee@comcast.com>

denisok · 2021-12-10T14:48:40Z

@maxknee it is and error from Docker file when it tries to build it:
https://github.com/percona/rds_exporter/blob/main/Dockerfile#L9

For new pipeline that is unnecessary and probably doesn't work because there are no sources there (or they are in different location).

You probably need to add new docker file and specify it in the goreleaser:
dockerfile: Dockerfile.release

Or rework existing Dockerfile (btw pay attention to the yml, it should be in the container on that path)

Signed-off-by: Max Knee <Max_Knee@comcast.com>

Dockerfile

yonahd · 2021-12-13T09:29:25Z

@denisok I don't think a release will be able to be created without the tests passing

denisok · 2021-12-13T11:06:58Z

@yonahd those test failed because they couldn't run from the forked repo. We would run test one way or another.

yonahd · 2021-12-13T16:05:16Z

@denisok isn't the goal to create a new release?

denisok · 2021-12-14T09:44:58Z

@yonahd didn't get you. Yes the goal is to create new release. And thus tests need to pass.
https://github.com/percona/rds_exporter/issues/74

* adding .goreleaser.yml Signed-off-by: Max Knee <Max_Knee@comcast.com> * adding new line Signed-off-by: Max Knee <Max_Knee@comcast.com> * Apply suggestions from code review Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com> * Update .goreleaser.yml * adding releaser action Signed-off-by: Max Knee <Max_Knee@comcast.com> * Update release.yml * Update .goreleaser.yml * maxknee test docker build Signed-off-by: Max Knee <Max_Knee@comcast.com> * adding go 1.16 Signed-off-by: Max Knee <Max_Knee@comcast.com> * debugging action Signed-off-by: Max Knee <Max_Knee@comcast.com> * updating dockerfile Signed-off-by: Max Knee <Max_Knee@comcast.com> * reverting docker file and adding new releaserfile Signed-off-by: Max Knee <Max_Knee@comcast.com> Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>

* Create rds_exporter-component.yaml * PMM-6120 Use go 1.14 (percona#45) * PMM-6213 Remove go 1.13 from travis. (percona#46) * PMM-6213 Remove go 1.13 from travis. * PMM-6213 Add go 1.15.x * PMM-6213 Add go tip. * PMM-6756 Added go 1.15.x. (percona#48) * [PMM-6756] Added go 1.15.x. * PMM-6756 Update * PMM-6756 Update * PMM-6756 Revert * Dummy * PMM-6756 Update golden files Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com> Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com> * Overcome the limitation of 100 dbinstances (percona#47) * ci: rotate integration keys (percona#52) * Delete .travis.yml * PMM-7602 Add GitHub Action (percona#53) * PMM-7602 Add GitHub Action * PMM-7602 Point actions to forked repo. * PMM-7602 Removed travis. * PMM-7602 Use go modules. * PMM-7602 Fix check. * PMM-7602 Fix mod. * PMM-7602 Fix setup. * PMM-7602 Fix setup. * PMM-7602 Fix setup. * add environment * PMM-7602 Fix tests. * PMM-7602 Fix codecov * PMM-7602 defines what to use go get or go install * PMM-7602 Improve go get/install * PMM-7602 Improve get promu. * PMM-7602 Use tools module for tooling. * PMM-7602 Fix mods. * PMM-7602 Fix path * PMM-7602 Fix gocoverutil Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com> * PPMM-7961 Updated exporter_shared (percona#59) * PMM-7902 Remove Go 1.15 (percona#60) * Add docker multistage build (percona#61) * bring back maxInterval=60 sec (percona#63) Co-authored-by: Volodymyr Linevych <vlin@hellofresh.com> Co-authored-by: Volodymyr Linevych <4980689+vlinevych@users.noreply.github.com> * PMM-8207 Cleanup. (percona#57) Co-authored-by: Jiri Ctvrtka <jiri.ctvrtka.sde@gmail.com> * add the ReplicaLag metric (percona#51) * Update README.md (percona#65) Remove mentioning upstream as we reworked the project entirely. This statement can confuse people * PMM-6013 change default branch to main (percona#67) * Support assume role (percona#70) * assume role * move credentials into session * adding .goreleaser.yml (percona#72) * adding .goreleaser.yml Signed-off-by: Max Knee <Max_Knee@comcast.com> * adding new line Signed-off-by: Max Knee <Max_Knee@comcast.com> * Apply suggestions from code review Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com> * Update .goreleaser.yml * adding releaser action Signed-off-by: Max Knee <Max_Knee@comcast.com> * Update release.yml * Update .goreleaser.yml * maxknee test docker build Signed-off-by: Max Knee <Max_Knee@comcast.com> * adding go 1.16 Signed-off-by: Max Knee <Max_Knee@comcast.com> * debugging action Signed-off-by: Max Knee <Max_Knee@comcast.com> * updating dockerfile Signed-off-by: Max Knee <Max_Knee@comcast.com> * reverting docker file and adding new releaserfile Signed-off-by: Max Knee <Max_Knee@comcast.com> Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com> * Update Dockerfile.releaser * Update .goreleaser.yml * Update .goreleaser.yml * Update release.yml * Update release.yml * cost exclaimer (percona#73) * cost exclaimer and docker push * Update Makefile Remove change of makefile * PMM-9337 Update go 1.17 (percona#77) * PMM-9337 Update go 1.17 * Fix codecov Co-authored-by: JiriCtvrtka <62988319+JiriCtvrtka@users.noreply.github.com> * Fix incorrect version (percona#76) * Fix incorrect version. * FIx for releaser itself. * Removing promu. * Delete another file related to promu. * update ldflags update ldflags to fill correct values for version * Remove make build. * Tidy. * Revert "Tidy." This reverts commit 472ca26. * add prometheus again * add required packages * Remove make tarball from CI. * Remove make tarball * trigger Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com> * PMM-11049 Typo present in enhanced metrics scraper for rds_exporter (percona#82) Co-authored-by: cezmunsta <github@incoming-email.co.uk> * PMM-11312 --version (percona#84) * PMM-11312 --version * PMM-11312 make feature-build * PMM-11312 newline * PMM-11312 rename command * PMM-11312 just update version * PMM-7 Add dependabot (percona#85) * PMM-11497 Update dependencies. (percona#87) * PMM-11632 rds_exporter ignores DisableEnhancedMetrics (percona#91) * Discord link has been removed (percona#92) * PMM-12339 remove go tip (percona#94) * PMM-12339 remove go tip PMM-12339 https://goreleaser.com/deprecations/?h=rm+dist#-rm-dist * PMM-12339 refactor go workflow * PMM-12339 Hix CI * PMM-12339 avoid triggering tests twice --------- Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com> * Rename build to builder * golang 1.19 * Patch dist --------- Co-authored-by: Eduardo Rodrigues Semensati <24209506+EduSemensati@users.noreply.github.com> Co-authored-by: Andrii Skomorokhov <askomorokhov@users.noreply.github.com> Co-authored-by: Jaroslav Musil <49949480+yareach@users.noreply.github.com> Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com> Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com> Co-authored-by: Volodymyr Linevych <4980689+vlinevych@users.noreply.github.com> Co-authored-by: Alex Tymchuk <alexander.tymchuk@percona.com> Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com> Co-authored-by: Carlos Salguero <carlos.salguero@percona.com> Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com> Co-authored-by: Volodymyr Linevych <vlin@hellofresh.com> Co-authored-by: Jiri Ctvrtka <jiri.ctvrtka.sde@gmail.com> Co-authored-by: ben lovett <blovett@users.noreply.github.com> Co-authored-by: Roma Novikov <roma.novikov@percona.com> Co-authored-by: Nikita Beletskii <nikita.beletskii@percona.com> Co-authored-by: Yonah Dissen <47282577+yonahd@users.noreply.github.com> Co-authored-by: Max Knee <maxknee@gmail.com> Co-authored-by: JiriCtvrtka <62988319+JiriCtvrtka@users.noreply.github.com> Co-authored-by: cezmunsta <github@incoming-email.co.uk> Co-authored-by: Yaroslav Podorvanov <63663261+YaroslavPodorvanov@users.noreply.github.com> Co-authored-by: Artem Gavrilov <charlieblackwood7@gmail.com> Co-authored-by: Przemyslaw Kadej <przemyslaw@kadej.org> Co-authored-by: Daniil Bazhenov <mail@dbazhenov.ru> Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>

adding .goreleaser.yml

b8d1ed2

Signed-off-by: Max Knee <Max_Knee@comcast.com>

denisok added the community label Dec 8, 2021

denisok requested review from anton-bystrov, percona-csalguero and JiriCtvrtka December 8, 2021 16:13

adding new line

b674b98

Signed-off-by: Max Knee <Max_Knee@comcast.com>

denisok reviewed Dec 8, 2021

View reviewed changes

.goreleaser.yml Outdated Show resolved Hide resolved

Apply suggestions from code review

68d8535

Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>

denisok and others added 2 commits December 8, 2021 18:14

Update .goreleaser.yml

fbc51a0

adding releaser action

d288b03

Signed-off-by: Max Knee <Max_Knee@comcast.com>

maxknee force-pushed the add-releaser branch from cb3d0c7 to d288b03 Compare December 8, 2021 17:27

denisok added 2 commits December 9, 2021 10:57

Update release.yml

b4447da

Update .goreleaser.yml

ddedbd8

maxknee and others added 2 commits December 9, 2021 11:43

Merge pull request #1 from maxknee/add-releaser

199f015

Add releaser

maxknee test docker build

3740740

Signed-off-by: Max Knee <Max_Knee@comcast.com>

Max Knee and others added 4 commits December 9, 2021 12:12

adding go 1.16

af8bcbe

Signed-off-by: Max Knee <Max_Knee@comcast.com>

debugging action

668f325

Signed-off-by: Max Knee <Max_Knee@comcast.com>

updating dockerfile

6ddde2f

Signed-off-by: Max Knee <Max_Knee@comcast.com>

Merge branch 'main' into add-releaser

e196dd5

yonahd mentioned this pull request Dec 10, 2021

cost exclaimer #73

Merged

reverting docker file and adding new releaserfile

01d4cad

Signed-off-by: Max Knee <Max_Knee@comcast.com>

denisok suggested changes Dec 10, 2021

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

denisok self-requested a review December 10, 2021 20:19

denisok approved these changes Dec 10, 2021

View reviewed changes

percona-csalguero approved these changes Dec 10, 2021

View reviewed changes

denisok merged commit 5a35fd1 into percona:main Dec 13, 2021

maxknee deleted the add-releaser branch December 13, 2021 14:08

denisok added this to the 0.7.2 milestone Dec 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding .goreleaser.yml #72

adding .goreleaser.yml #72

maxknee commented Dec 8, 2021 •

edited

Loading

it-percona-cla commented Dec 8, 2021 •

edited

Loading

denisok commented Dec 8, 2021

maxknee commented Dec 8, 2021

denisok commented Dec 8, 2021

maxknee commented Dec 8, 2021

denisok commented Dec 8, 2021

denisok commented Dec 9, 2021

maxknee commented Dec 9, 2021

denisok commented Dec 10, 2021

yonahd commented Dec 13, 2021

denisok commented Dec 13, 2021

yonahd commented Dec 13, 2021

denisok commented Dec 14, 2021

adding .goreleaser.yml #72

adding .goreleaser.yml #72

Conversation

maxknee commented Dec 8, 2021 • edited Loading

it-percona-cla commented Dec 8, 2021 • edited Loading

denisok commented Dec 8, 2021

maxknee commented Dec 8, 2021

denisok commented Dec 8, 2021

maxknee commented Dec 8, 2021

denisok commented Dec 8, 2021

denisok commented Dec 9, 2021

maxknee commented Dec 9, 2021

denisok commented Dec 10, 2021

yonahd commented Dec 13, 2021

denisok commented Dec 13, 2021

yonahd commented Dec 13, 2021

denisok commented Dec 14, 2021

maxknee commented Dec 8, 2021 •

edited

Loading

it-percona-cla commented Dec 8, 2021 •

edited

Loading