Introduce multiple storage drivers #28
Conversation
Add support for different serialization options: json, serialize, igbinary. Add support to save meta information to separate file - to speed up gui operations. Add information how to make output compatible with original gui and other tools. Add option to store additional data with profile information such as db queries (copied from globals). Fallback to default if config option is missing.
code clean up config clean up
remove some warnings/notices
Fix id from mongo (with underscore)
|
@markstory Ready for merge. But if I change package names from grzegorzdrozd/xhgui|grzegorzdrozd/xhgui-collector it will not build - unit tests will fail. Please review and when you are happy I will change them back to default, ok? |
|
@GrzegorzDrozd could you please rebase to squash commits to a minimum. I can do the review as well. |
- revert short array syntax - fix typos - rename PDO class to Pdo - change session existence check
- fix version compare
- remove unused config values - remove unnecessary complex logic in filename generation
- remove unnecessary code formatting - make sure no array is using short syntax
| } | ||
|
|
||
| // try php 7+ function. | ||
| if (function_exists('random_bytes')) { |
There was a problem hiding this comment.
remove the function_exists check. and all the compatibility layer done below. the function is provided by php engine or the random-compat shim.
I wrote about this elsewhere in this PR.
|
What is this different from #11? as it already added a PDO adapter? |
|
this is not suitable for merge or review. submit changes in smaller chunks and per feature. currently, it seems to branched off before #11 was submitted, and impossible at the current state. |
Changes required by: perftools/xhgui#273 (formerly perftools/xhgui#268)
Introduce multiple storage drivers, currently supported are: