Skip to content
This repository has been archived by the owner on Sep 26, 2020. It is now read-only.

Backend decoupling #11

Merged
merged 13 commits into from
Apr 24, 2019
Merged

Backend decoupling #11

merged 13 commits into from
Apr 24, 2019

Conversation

1ma
Copy link
Contributor

@1ma 1ma commented Jul 8, 2018

Companion PR for perftools/xhgui#244 (also Work in Progress)

The same thing applies with regards to the configuration, the only difference is that instead of consuming profiles, the collector stores them in the database (automatically creating the table when it still doesn't exist).

When both PRs are ready this one should be merged and tagged first.

composer.json Outdated Show resolved Hide resolved
@glensc
Copy link
Contributor

glensc commented Mar 19, 2019

@1ma what is left to do here that this is still marked WIP, can you add tasklist like in the other PR?

@glensc
Copy link
Contributor

glensc commented Mar 26, 2019

@markstory imho the collector part is ready for merge [1], with the composer change [2].

i can create PR from my repo to add the change and you can merge?

ps: i invited you to my php-profiler version, you did not get the invite?

@1ma
Copy link
Contributor Author

1ma commented Mar 26, 2019

@1ma what is left to do here that this is still marked WIP, can you add tasklist like in the other PR?

Yes, I'll see if I can manage. This has been sleeping for quite some time now.

@glensc
Copy link
Contributor

glensc commented Mar 27, 2019

actually, I think this could become the next generation of the library: https://github.com/glensc/php-profiler/pull/1

cc @lauripiisang

@1ma 1ma changed the title WIP: Backend decoupling Backend decoupling Apr 23, 2019
@1ma
Copy link
Contributor Author

1ma commented Apr 23, 2019

I just completed a review of both PRs, had not visited the code for some months. I agree, I think this one is ready for merging and tagging.

@1ma 1ma mentioned this pull request Apr 24, 2019
9 tasks
@glensc
Copy link
Contributor

glensc commented Apr 24, 2019

thanks @1ma. merging and making a release

@glensc glensc merged commit 1388249 into perftools:master Apr 24, 2019
@1ma 1ma deleted the backend-decoupling branch April 24, 2019 16:44
glensc added a commit to perftools/php-profiler that referenced this pull request Apr 20, 2020
It's already there by xhgui-collector 1.8:

- perftools/xhgui-collector#11
glensc added a commit to perftools/php-profiler that referenced this pull request Apr 20, 2020
It's already there by xhgui-collector 1.7.0:

- perftools/xhgui-collector#11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants