-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
@1ma what is left to do here that this is still marked |
@markstory imho the collector part is ready for merge [1], with the composer change [2]. i can create PR from my repo to add the change and you can merge? ps: i invited you to my php-profiler version, you did not get the invite? |
Yes, I'll see if I can manage. This has been sleeping for quite some time now. |
actually, I think this could become the next generation of the library: https://github.com/glensc/php-profiler/pull/1 |
…hen importing an array of profiles from the import controller
I just completed a review of both PRs, had not visited the code for some months. I agree, I think this one is ready for merging and tagging. |
thanks @1ma. merging and making a release |
It's already there by xhgui-collector 1.8: - perftools/xhgui-collector#11
It's already there by xhgui-collector 1.7.0: - perftools/xhgui-collector#11
Companion PR for perftools/xhgui#244 (also Work in Progress)
The same thing applies with regards to the configuration, the only difference is that instead of consuming profiles, the collector stores them in the database (automatically creating the table when it still doesn't exist).
When both PRs are ready this one should be merged and tagged first.