Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PdoSaver: Allow _id override for unit testing #339

Merged
merged 2 commits into from
Sep 30, 2020
Merged

PdoSaver: Allow _id override for unit testing #339

merged 2 commits into from
Sep 30, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Sep 24, 2020 •
edited
Loading

Similarly in MongoSaver:

refs:

this includes a fix to backends disparity:

@glensc glensc self-assigned this Sep 24, 2020
@glensc glensc mentioned this pull request Sep 24, 2020
Closed
@glensc
Cleanup getLastProfilingId from MongoSaver
71933ae 
This no longer makes sense as profile savers from applications are in
standalone library, so the value reuse here is impossible.
@glensc
PdoSaver: Allow _id override for unit testing
94d0e02
@glensc glensc merged commit 8c90bbe into master Sep 30, 2020
@glensc glensc deleted the id-override branch September 30, 2020 19:57
glensc added a commit that referenced this pull request Oct 12, 2020
@glensc
Drop unused MongoSaver::lastProfilingId. #339
b2aae92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glensc