Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply automatic code fixes for php 7.2 target #400

Merged
merged 5 commits into from
Dec 23, 2020
Merged

Apply automatic code fixes for php 7.2 target #400

merged 5 commits into from
Dec 23, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Dec 23, 2020 •
edited
Loading

  • Apply void_return fixer
  • Apply visibility_required fixer
  • Apply list_syntax fixer

@glensc glensc added this to the Next milestone Dec 23, 2020
@glensc glensc self-assigned this Dec 23, 2020
@glensc
Copy link
Contributor Author

glensc commented Dec 23, 2020

@markstory stickler-ci Failing again and the link points to URL that I can not access:

@glensc
Copy link
Contributor Author

glensc commented Dec 23, 2020 •
edited
Loading

@markstory stickler-ci Failing again and the link points to URL that I can not access:

Update: The errors can be seen from Checks tab:

@glensc glensc changed the title Apply void_return fixer Apply automatic code fixes for php 7.2 target Dec 23, 2020
@glensc glensc marked this pull request as ready for review December 23, 2020 15:32
@glensc glensc merged commit e729eaf into master Dec 23, 2020
@glensc glensc deleted the cs-fixes branch December 23, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
1 participant
@glensc