This repository has been archived by the owner on May 23, 2023. It is now read-only.
Fix problem with complex values injected through env var will broke HOCON config parser #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com:Arkatufus/akkadotnet-bootstrap into Fix_bad_value_from_env_corrupts_hocon_config
Aaronontheweb
added a commit
that referenced
this pull request
Apr 3, 2021
* Update common.props * Bump Akka from 1.4.14 to 1.4.17 (#122) Bumps [Akka](https://github.com/akkadotnet/akka.net) from 1.4.14 to 1.4.17. - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.14...1.4.17) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk from 16.8.3 to 16.9.1 (#121) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.8.3...v16.9.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Aaron Stannard <aaron@petabridge.com> * Bump Akka from 1.4.17 to 1.4.18 (#125) Bumps [Akka](https://github.com/akkadotnet/akka.net) from 1.4.17 to 1.4.18. - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.17...1.4.18) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump Petabridge.Cmd.Remote from 0.8.2 to 0.8.3 (#124) Bumps Petabridge.Cmd.Remote from 0.8.2 to 0.8.3. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump Petabridge.Cmd.Cluster from 0.8.2 to 0.8.3 (#123) Bumps Petabridge.Cmd.Cluster from 0.8.2 to 0.8.3. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4 (#127) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.9.1 to 16.9.4. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v16.9.1...v16.9.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * close #115 - do not assign default host name if assignDefaultHostName param is false. (#126) Co-authored-by: Aaron Stannard <aaron@petabridge.com> * modernized build system (#130) * Fix problem with complex values injected through env var will broke HOCON config parser (#131) * Fix problem with complex values injected through env var will broke HOCON config parser * Change newline check from specific to generic to harden it Co-authored-by: Aaron Stannard <aaron@petabridge.com> * Update RELEASE_NOTES.md (#132) Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Erik Følstad <erikmafo@gmail.com> Co-authored-by: Gregorius Soedharmo <arkatufus@yahoo.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any values that needs to be quoted in HOCON ( containing any character in the set [$"{}[]:=,#`^?!@*&] and the new line character) will break the HOCON parser and generates an unchecked invalid HOCON config that can cause unpredictable errors in Akka.