This repository has been archived by the owner on May 23, 2023. It is now read-only.
Array handling rollback and improvements #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arkatufus
commented
Mar 5, 2020
Arkatufus
commented
- Rollback angle brackets requirement for array declaration
- Re-add missing console output
- More robust string value handling for environment variable akka injection.
…-rc1 # Conflicts: # src/Akka.Bootstrap.Docker.Tests/DockerBootstrapSpecs.cs # src/Akka.Bootstrap.Docker/EnvironmentVariableConfigLoader.cs
Aaronontheweb
suggested changes
Mar 5, 2020
| if (string.IsNullOrWhiteSpace(source)) | ||
| return string.Empty; | ||
|
|
||
| if (source.First() == '[' && source.Last() == ']') |
There was a problem hiding this comment.
So we detect an array here
There was a problem hiding this comment.
What happens for source == string.Empty ? (need a test)
| return sb.ToString(); | ||
| } | ||
|
|
||
| public static string ToSafeHoconString(this string value) |
There was a problem hiding this comment.
Need to add some tests to cover this
Aaronontheweb
approved these changes
Mar 5, 2020
Aaronontheweb
added a commit
to Aaronontheweb/akkadotnet-bootstrap
that referenced
this pull request
Mar 10, 2020
This reverts commit c28e967.
Aaronontheweb
added a commit
that referenced
this pull request
Mar 10, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.