Merge pull request #117 from AndyMan1/del_closed_attr

fix AttributeError in Queue.__del__
peter-wangxu · Nov 1, 2019 · 25c8472 · 25c8472
2 parents 9edb318 + 30674cf
commit 25c8472
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/persistqueue/queue.py b/persistqueue/queue.py
@@ -296,6 +296,6 @@ def _infopath(self):
 
     def __del__(self):
         """Handles the removal of queue."""
-        for to_close in [self.headf, self.tailf, self.info]:
+        for to_close in [self.headf, self.tailf]:
             if to_close and not to_close.closed:
                 to_close.close()
diff --git a/persistqueue/tests/test_queue.py b/persistqueue/tests/test_queue.py
@@ -281,3 +281,11 @@ def test_protocol(self):
         q = Queue(path=self.path, serializer=serializer)
         q.put(b'a')
         self.assertEqual(q.get(), pickle.dumps(b'a', protocol=expect_protocol))
+
+    @params(*serializer_params)
+    def test_del(self, serializer):
+        """test that __del__ can be called successfully"""
+        q = Queue(self.path, **serializer_params[serializer])
+        q.__del__()
+        self.assertTrue(q.headf.closed)
+        self.assertTrue(q.tailf.closed)