fix AttributeError in Queue.__del__ #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queue.__del__
attempts to useclosed
andclose()
onself.info
, butself.info
is a dict and there's nothing to close. Just removing it from the removal list.example (python 3.6):
I think because this happens in
__del__
, you can see the exception is ignored rather than raised. So the unit tests definitely complain about this but succeed regardless. Not sure how to write a unit_test around that very peculiar scenario.