Disable slashcommand and flake requirements #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is PAT different from the GitHub Secrets for the (test) tool shed API tokens? If we're only missing tool shed tokens, I would have expected the lint and tests to still be run. -- The flake8 changes look good as a proof of principle implementation for galaxyproject/tools-iuc#4988 (other than a trailing white space in the YAML, and missing final new line in the requirements file) |
|
This is only used in the slash worklflow .. it would need to be a PAT https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token see also https://github.com/peter-evans/slash-command-dispatch#token But you don't need this (except if you want to trigger the test of all tools out of schedule) |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the slash workflow (which reacts on all comments and looks for
/run-all-tool-tests) always fails because the PAT is not defined. Guess it would be cool to run this only if PAT is defined (not sure if it will work the way I implemented it).Also introduces .flake8_requirement file as discussed. If useful and working then we can add it to IUC.