-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IUC workflows reusable #4830
base: main
Are you sure you want to change the base?
Make IUC workflows reusable #4830
Conversation
and changed for testing pr workflow
@bernt-matthias Can you take a look at the conflicts please? |
Will do. Seems that two PR were merged during my vacation:
|
from - galaxyproject#4850 - galaxyproject#4892 and fix fork (use IUC master for called WFs, instead of my fork)
Reminder:
Note that the WF does not run because of |
analogous to 6cccc56 this will also add it to the PR workflow (which cant hurt)
9588a7d
to
0a15fb8
Compare
48af3db
to
a6e74c0
Compare
a6e74c0
to
b247248
Compare
Integrate peterjc/galaxy_blast#151 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, let's do this!
As discussed on gitter I will try to add the called workflows to the planemo-ci-action repo. Putting this to draft until it is done. |
This PR adds:
galaxy-branch
will be updated automatically per default once its updated at IUC. Still users can fix the branch if they like. Also parameters for linting and testing are by default as they are at IUC, but can be overwritten.tool-util
,...) andplanemo
will impact more repos by default (if repos do not fix the for and branch). I would argue that this is good because it might help to detect bugs early.master
tomain
, since called worflows apparently can't refer to the default branch. otherwise we would need to change the calling workflows again.report-level
andfail-level
planemo-version
parameter to slash command which should allow to test planemo releasesplanemo-version="planemo==0.74"
PAT
is defined (only relevant for template repo .. once synced .. there the problem is that the slash workflow always fails untilPAT
is defined .. which is a bit annoying since it runs on every comment)The PR can also be seen in action here: galaxyproject/galaxy-tool-repository-template#11
TODOs:
FOR CONTRIBUTOR: