Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IUC workflows reusable #4830

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Oct 4, 2022

This PR adds:

  1. Reusable Workflows which can be used in all IUC style repos
    • The hope/aim is that users of these workflows will need to update/sync their workflows less often. In particular the galaxy-branch will be updated automatically per default once its updated at IUC. Still users can fix the branch if they like. Also parameters for linting and testing are by default as they are at IUC, but can be overwritten.
    • Bugs in Galaxy (tool-util,...) and planemo will impact more repos by default (if repos do not fix the for and branch). I would argue that this is good because it might help to detect bugs early.
    • TODO it would be handy if we could do the switch from master to main, since called worflows apparently can't refer to the default branch. otherwise we would need to change the calling workflows again.
  2. Adds report-level and fail-level
  3. Add planemo-version parameter to slash command which should allow to test planemo releases
    • usage, e.g. planemo-version="planemo==0.74"
  4. Update all called actions
    • checkout v2 -> v3
    • cache v2 -> v3
    • upload-artifact v2 -> v3
    • download-artifact v2 -> v3
    • setup-python v1 -> v4
    • peter-evans/create-or-update-comment v1 -> v2
    • peter-evans/slash-command-dispatch v2 -> v3
  5. Make used flake8 plugins configurable fixes Make flake8 plugins configurable #4988
  6. Execute slash command only if PAT is defined (only relevant for template repo .. once synced .. there the problem is that the slash workflow always fails until PAT is defined .. which is a bit annoying since it runs on every comment)

The PR can also be seen in action here: galaxyproject/galaxy-tool-repository-template#11

TODOs:

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@bernt-matthias bernt-matthias changed the title Topic/reusable workflows Make IUC workflows reusable and migrate autoupdate workflow Oct 4, 2022
@bernt-matthias bernt-matthias changed the title Make IUC workflows reusable and migrate autoupdate workflow Make IUC workflows reusable Oct 6, 2022
@nsoranzo
Copy link
Member

@bernt-matthias Can you take a look at the conflicts please?

@bernt-matthias
Copy link
Contributor Author

Will do. Seems that two PR were merged during my vacation:

from

- galaxyproject#4850
- galaxyproject#4892

and fix fork (use IUC master for called WFs, instead of my fork)
@bernt-matthias
Copy link
Contributor Author

bernt-matthias commented Nov 17, 2022

Reminder:

  • remove test bumps of tools before merging

Note that the WF does not run because of error parsing called workflow "galaxyproject/tools-iuc/.github/workflows/wf_lint.yaml@master": failed to fetch workflow: workflow was not found. .. If you like I could change it temporarily to the branch in my for to see it in action?

analogous to 6cccc56

this will also add it to the PR workflow (which cant hurt)
@bernt-matthias bernt-matthias force-pushed the topic/reusable-workflows branch from 9588a7d to 0a15fb8 Compare November 27, 2022 16:31
@bernt-matthias bernt-matthias force-pushed the topic/reusable-workflows branch from a6e74c0 to b247248 Compare December 8, 2022 09:13
@bernt-matthias
Copy link
Contributor Author

Integrate peterjc/galaxy_blast#151

Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's do this!

@bernt-matthias
Copy link
Contributor Author

As discussed on gitter I will try to add the called workflows to the planemo-ci-action repo. Putting this to draft until it is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make flake8 plugins configurable
3 participants