-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are source URLs getting incorrectly URL-decoded? #359
Comments
@snarfed might be perhaps an issue with the Mf2 parser, because it supports fragment-parsing. |
@snarfed is the author outside of the fragment? |
The source URL doesn't contain a fragment, it contains Ideally the plugins/parser would leave that |
This is a really good question! |
I would assume that they have to be URL encoded because otherwise an |
And the content type is: |
I've confirmed that browsers URL-encode, so a form-encoded POST with key |
I've also confirmed that my code is doing the same thing, ie the
Note the |
OK, that might be possible because of the interaction of both (Webmention & SL) plugins, I will re-check the latest version of the Webmention plugin. |
Looks like this isn't about the
If I send a webmention with this source, I get:
Same if I %-encode the
However, if I double-encode those chars to
|
Here are example WP debug logs I see for a failed webmention with a source URL with
The full source URL was Btw this is on pre-merge plugins, ie Webmention 4.0.9 and Semantic-Linkbacks 3.12.0. |
Why do people put everything in URLs...??? (and please do not answer with: because they can |
Hah, fair point, maybe I'm being a bit difficult here. Sorry! This bug does seem unrelated to any individual characters though, since it happens when they're URL-encoded too, eg the examples here with both I'm open to other ideas! I need to be able to include arbitrary URLs, including ones with |
|
It is at least no double encoding or something similar. |
Odd: I switched back from |
@snarfed that make sense, because if you check the HTML of the fed.brid.gy links (vs the AP links), then you find only an h-card without any context... that's why the plugin ignores them, it does not know how to handle them... |
Hmm! You're right about the top source URL in the original description, https://fed.brid.gy/render?id=https%3A%2F%2Findieweb.social%2Fusers%2Fsnarfed%23likes%2F709275 . Not sure what's going on there. The rest of the source URLs here are valid |
Hi @dshanske @pfefferle! I'm seeing an odd issue with source URLs with URL-encoded
#
characters, eg https://fed.brid.gy/render?id=https%3A%2F%2Findieweb.social%2Fusers%2Fsnarfed%23likes%2F709275 . That page has au-like-of
with a fullp-author h-card
, with name and photo, but when WordPress receives it as a webmention source, Semantic-Linkbacks doesn't find that author at all.However, if I double-URL-encode the
#
character, ie https://fed.brid.gy/render?id=https%3A%2F%2Findieweb.social%2Fusers%2Fsnarfed%2523likes%2F709275 , the webmention works fine and correctly shows the author name and image.I know URLs with
#
s are awkward, even when URL-encoded, but the first source URL is working ok with other wm receivers, eg https://www.jvt.me/week-notes/2023/09/ (scroll down and expand Interactions with this post), so I suspect this is a bug in this plugin or Semantic-Linkbacks?Thanks in advance!
The text was updated successfully, but these errors were encountered: