Update dupe check #386
Merged
Update dupe check #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes me wonder if we shouldn't migrate to source_url to match activitypub. |
dshanske
commented
Apr 16, 2023
| ( isset( $commentdata['comment_type'] ) && 'webmention' === $commentdata['comment_type'] ) || | ||
| ( isset( $commentdata['comment_meta'] ) && ! empty( $commentdata['comment_meta']['semantic_linkbacks_type'] ) ) | ||
| ) { | ||
| if ( ! empty( $commentdata['comment_meta']['protocol'] ) && 'webmention' === $commentdata['comment_meta']['protocol'] ) { |
There was a problem hiding this comment.
This is a check that is only supposed to be triggered on a Webmention, but no issue with an existence check
pfefferle
reviewed
Apr 16, 2023
|
I don't think we do. Don't we have to decode them? |
|
for reference: #359 (comment) |
|
@dshanske not decode, but encode! Because they are saved encoded didn't they? |
|
This is how I confuse myself |
|
😊 I think we should add some tests, to see what is correct! |
|
I would love to use this, to add some tests. Maybe @snarfed has some "special" URLs for us ;) |
|
@pfefferle Do you want to merge this and do the urlencode testing as a separate PR? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the dupe check parameters to search for dupes by matching on webmention_source_url, url, _crossposting_link or source_url in one query instead of multiple queries.
webmention_source url = the original source url
url = the canonical url in the event of something like a Bridgy post
_crossposting_link for Salmon
source_url for ActivityPub