Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some webmention receivers can't handle like/repost URLs with URL-encoded ^^s or #s #581

Closed
Mirakelor opened this issue Jul 11, 2023 · 7 comments

Comments

@Mirakelor
Copy link

In an attempt to test it, I liked the post.
But when the fed sent webmentions to my original post, something went wrong.
image
And I tried to send webmentions from here myself.
It succeeded.
image
Thanks For Help❤️.

@Mirakelor
Copy link
Author

#aaronpk/webmention.io#152

@snarfed
Copy link
Owner

snarfed commented Jul 11, 2023

Sigh yeah the WordPress webmention plugin also has trouble with those URLs, pfefferle/wordpress-webmention#359 , lots more background discussion there. Ugh.

@snarfed snarfed changed the title Webmention Failed Some webmention receivers can't handle like/repost URLs with URL-encoded ^^s or #s Jul 16, 2023
snarfed added a commit that referenced this issue Jul 24, 2023
for #581. the ^^s didn't help with WordPress, which was the original motivation, and they're confusing everyone else.
@snarfed
Copy link
Owner

snarfed commented Jul 24, 2023

The ^^s didn't help with WordPress, and they're consistently confusing everyone else, so I've switched BF back to URL-encoded # ie %23.

@snarfed
Copy link
Owner

snarfed commented Jul 29, 2023

@aaronpk @dshanske @pfefferle just a heads up, ^ Bridgy Fed is back to using plain %23s (URL-encoded #s) in its webmention source URLs now, so I suspect any remaining incompatibilities are on the webmention.io and WordPress plugin sides. Open issues mentioned above, let me know if I can do anything to help!

@pfefferle
Copy link

pfefferle commented Jul 31, 2023

I am not sure if it is an issue with the # or because of the empty content. The Webmention tools seems to have a correct result:

{
	"mf2": {
		"url": "https:\/\/indieweb.social\/@snarfed",
		"author": {
			"type": "card",
			"name": "Ryan Barrett",
			"nickname": "snarfed",
			"url": "https:\/\/indieweb.social\/@snarfed",
			"photo": "https:\/\/cdn.masto.host\/indiewebsocial\/accounts\/avatars\/109\/130\/869\/961\/539\/408\/original\/6a96256645c6c1f4.png"
		},
		"photo": "https:\/\/cdn.masto.host\/indiewebsocial\/accounts\/avatars\/109\/130\/869\/961\/539\/408\/original\/6a96256645c6c1f4.png",
		"response_type": "mention",
		"raw": {
			"type": ["h-card"],
			"properties": {
				"uid": ["https:\/\/indieweb.social\/users\/snarfed"],
				"name": ["Ryan Barrett"],
				"nickname": ["snarfed"],
				"url": ["https:\/\/indieweb.social\/@snarfed"],
				"photo": ["https:\/\/cdn.masto.host\/indiewebsocial\/accounts\/avatars\/109\/130\/869\/961\/539\/408\/original\/6a96256645c6c1f4.png"]
			}
		}
	},
	"meta": [],
	"jsonld": {
		"response_type": "mention"
	}
}

But content is currently a required field.

@snarfed
Copy link
Owner

snarfed commented Jul 31, 2023

Do you mean content is required by the WP plugin? That's surprising; Bridgy (non-Fed) likes and reposts have pretty much never had content, and they've been working fine. Example: https://brid.gy/like/twitter/schnarfed/1636053621715656709/14111671 on https://snarfed.org/2023-03-15_49548

@snarfed
Copy link
Owner

snarfed commented Jul 31, 2023

Interesting data point: now that I've switched BF back from ^^ to %23, I'm seeing some of these BF likes with %23 source URLs work after all. Example: https://ap.brid.gy/convert/web/https:/bayes.club/users/zerology%23likes/32983 on https://snarfed.org/2023-07-10_50589

I'm tentatively closing this in favor of pfefferle/wordpress-webmention#359 and aaronpk/webmention.io#152 . Happy to reopen it if it turns out to be a BF problem after all!

@snarfed snarfed closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants