-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clean blocks with dead context on debugger #15153
Fix clean blocks with dead context on debugger #15153
Conversation
Some unrelated tests are failing |
the failing tests look somehow related, as they are about blocks (but in Sindarin)
|
tests passed! |
Tests (Morphic) on OSX are crashing but I cannot reproduce it 👎 |
This is a known issue that I hope will be workaround with: pharo-spec/Spec#1467 all tests passed here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -469,7 +469,9 @@ EncoderForSistaV1 class >> isCreateBlockAt: pc in: method [ | |||
|
|||
| byte | | |||
byte := self nonExtensionBytecodeAt: pc in: method. | |||
^ byte = 250 | |||
^ byte = 250 or: [ | |||
(method sourceNodeForPC: pc) in: [ :node | "Clean blocks are created as PushConstant" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Falling back to the AST here is not that nice as it breaks the abstraction (the idea is that the bytecode level abstractions should be usable without the AST). But we could merge it for now and improve later, this is used only the the debugger which needs the AST anyway.
Fix #13779
sourceNodeForPC:
BytecodeEncoder >> isCreateBlockAt:in:
was resolved.Related PR: pharo-spec/NewTools#605