Guard removals of morphs in layouts #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of crashes in the Pharo CI because a test end up trying to remove a presenter from a layout but the presenter has no adapter. Guille told us that it was probably because in non interactive things might happens in different order because of the different threads. Here I'm adding nil guards to prevent those crashes (around 1/3 of each Pharo build end up crashing because of this) I don't know if this is a good solution to fix the root of the problem, but I have no idea how to fix better. I also removed some methods that just called super methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of crashes in the Pharo CI because of the UI. @MarcusDenker removed a catch to let us find the root of the problems. We found out that a test end up trying to remove a presenter from a layout but the presenter has no adapter. Guille told us that it was probably because in non interactive things might happens in different order because of the different threads.
Here I'm adding nil guards to prevent those crashes (around 1/3 of each Pharo build end up crashing because of this)
I don't know if this is a good solution to fix the root of the problem, but I have no idea how to fix better.
I also removed some methods that just called super methods