Use a Vimium class to detect click listeners. #3004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5745bb3 disabled our detection of click listeners added with `addEventListener` (see philc#2997 and philc#3002). This PR proposes using the CSS class list to inform Vimium that an element has a click listener (instead of a custom attribute).
|
@smblott-github Can I close this due to inactivity? The DOM injection strategy is currently disabled, and has always felt problematic to me. |
|
Closing to tidy up the PR queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5745bb3 disabled our detection of click listeners added with
addEventListener(see #2997 and #3002).This PR proposes using the CSS class list to inform Vimium that an element has a click listener (instead of a custom attribute).