unify initing processes of modes #3867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, what is needed to get this merged? |
gdh1995
force-pushed
the
init-visualmode-correctly
branch
from
9ad814f to
2ded136
Compare
gdh1995
force-pushed
the
init-visualmode-correctly
branch
from
2ded136 to
a7e7238
Compare
|
@philc bump. Carret mode needed |
|
Bump. Is there any reason a 1 year old pr that fixes a bug is not merged yet? |
|
bump. plz? |
|
Alright folks, sorry for the delay. @gdh1995 checking in again to see what you think of this vs. #4064 (which is also now equivalent to #3877)? The use of inheritance in the implementation of modes is unnecessarily complex and I'd like to greatly simplify it at some point. #4064 is a simpler patch (3 LOC change) because it doesn't introduce new constraints around using super. I think they both fix precisely the same set of bugs, correct? |
|
Yes it worths to merge #4064. |
|
Ok great -- closing this in favor of #3877. |
|
BTW, I've reviewed Vimium's current code and noticed that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug that some
new-ed modes are never inited, imported when migrating from CoffeeScript to ES6. This PR fixes this by forcing subclasses ofModeto callsuper.init()in their constructors.This fixes #3865, fixes #3866, fixes #3926, fixes #4062 and replaces #3877.