Cannot go to caret mode from normal mode

[tuanbass]

In recent releases, I cannot go to the caret mode (by press "vc") from Normal mode.
So I create this patch to have it back.

[twio142]

Hi, thanks for fixing the caret mode. :)

But there's one little bug here: In caret mode, forward word jumping using w or e acts just like in visual mode, but the selection only jumps forward the first time the key is pressed and then stops there. While in visual mode w and e do act properly.

I suppose it's due to the altering below (starting from line 55):

    // Native word movements behave differently on Linux and Windows, see #1441.  So we implement some of them
    // character-by-character.
    if (granularity === vimword && direction === forward) {
      while (this.nextCharacterIsWordCharacter())
        if (this.extendByOneCharacter(forward) === 0)
          return;
      while (this.getNextForwardCharacter() && !this.nextCharacterIsWordCharacter())
        if (this.extendByOneCharacter(forward) === 0)
          return;
    } else if (granularity === vimword) {
      return this.selection.modify(this.alterMethod, backward, word);
    }

FYI: I'm using Chrome 96 on Mac 10.15

[chuckmasucci]

Would love to see his merged!

[gdh1995]

@tuanbass Hello, you have pushed some new commits to the master branch of your repo, while it's about scrolling, but not VisualMode. This affects this PR because the PR is bound to tuanbass:master directly.

[tuanbass]

@tuanbass Hello, you have pushed some new commits to the master branch of your repo, while it's about scrolling, but not VisualMode. This affects this PR because the PR is bound to tuanbass:master directly.

Thanks for pointing out.
As the PR was opened for a long time, I have nearly forgotten about it, and tried to fix another bug.
Anyway, I reverted the last commit, and hope the PR will be merged soon.

[roryfahy]

Any idea when this will be merged? Would really benefit from this functionality. Thank you.

[philc]

This is great; thanks for the cleanup and the fix @tuanbass !

[gdh1995]

Just now I reviewed all my code in #3867, and I found this PR lacks a place:

vimium/content_scripts/mode_visual.js

Lines 380 to 383 in 66adcde

	"/"() {
	this.exit();
	return new FindMode({returnToViewport: true}).onExit(() => new VisualMode());
	},

Here a following .init() for new VisualMode() is also necessary. @philc

[philc]

Good catch @gdh1995; fixed in 5c00e2e