Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot go to caret mode from normal mode #3877

Merged
merged 7 commits into from
Oct 17, 2022
Merged

Cannot go to caret mode from normal mode #3877

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
261370f
switchable between view, viewline and caret mode
tuanbass Aug 4, 2021
53174e0
Merge pull request #1 from philc/master
tuanbass Apr 20, 2022
b58f7d1
Quick and dirty for infinite scroll issue
tuanbass May 18, 2022
428c8c0
Merge pull request #2 from philc/master
tuanbass May 30, 2022
7fbe04e
Merge pull request #3 from tuanbass/patch/infinite_scroll
tuanbass May 30, 2022
75add78
Revert "Infinite scroll issue"
tuanbass Jul 11, 2022
5244f48
Merge pull request #4 from tuanbass/revert-3-patch/infinite_scroll
tuanbass Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions content_scripts/mode_visual.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,8 @@ VisualMode.prototype.movements = {
"Y"(count) { this.movement.selectLine(count); return this.yank(); },
"p"() { return chrome.runtime.sendMessage({handler: "openUrlInCurrentTab", url: this.yank()}); },
"P"() { return chrome.runtime.sendMessage({handler: "openUrlInNewTab", url: this.yank()}); },
"v"() { return new VisualMode; },
"V"() { return new VisualLineMode; },
"v"() { return new VisualMode().init(); },
"V"() { return new VisualLineMode().init(); },
"c"() {
// If we're already in caret mode, or if the selection looks the same as it would in caret mode, then
// callapse to anchor (so that the caret-mode selection will seem unchanged). Otherwise, we're in visual
Expand All @@ -396,7 +396,7 @@ VisualMode.prototype.movements = {
this.movement.collapseSelectionToAnchor();
else
this.movement.collapseSelectionToFocus();
return new CaretMode;
return new CaretMode().init();
},
"o"() { return this.movement.reverseSelection(); }
};
Expand Down