Add support for parsing attributes as maps #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a feature request from #463 and is the base for implementing the same feature in more backends. Right now only the built-in `mochiweb` parser implements the feature.
josevalim
reviewed
Jun 10, 2023
josevalim
reviewed
Jun 10, 2023
Co-authored-by: José Valim <jose.valim@dashbit.co>
src/floki_mochi_html.erl
Outdated
| Attrs = [{norm(K, Opts), iolist_to_binary(V)} || {K, V} <- Attrs], | ||
| case lists:keyfind(attributes_as_maps, 1, Opts) of | ||
| {attributes_as_maps, true} -> | ||
| {norm(Tag, Opts), maps:from_list(Attrs), []}; |
There was a problem hiding this comment.
Documentation on maps:from_list says
If the same key appears more than once, the latter (right-most) value is used and the previous values are ignored.
This means for duplicate attributes the last instance is used in the map.
The HTML spec suggests that it's a parse error when you encounter multiple identical attributes (duplicate-attribute parse error), and that the parser ignores the duplicates (keeping the first).
There was a problem hiding this comment.
Great catch! Fixed in 708ad44
Thank you! 💜
This makes searching against a tree with attributes as maps work.
philss
added a commit
to rusterlium/html5ever_elixir
that referenced
this pull request
Jun 14, 2023
This is in line with Floki's new feature, that was introduced in philss/floki#467 The initial idea is from philss/floki#463
philss
added a commit
to rusterlium/html5ever_elixir
that referenced
this pull request
Jun 16, 2023
* Add parse functions that return attributes as maps This is in line with Floki's new feature, that was introduced in philss/floki#467 The initial idea is from philss/floki#463 * Improve error handling * Add a Rust CI workflow to check fmt and clippy * Add missing guard clause * Remove unused module and rename function * Omit "self::" to refer to local module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature request from #463 and is the base for implementing the same feature in more backends.
Right now only the built-in
mochiwebparser implements the feature.