Add parse functions that return attributes as maps #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in line with Floki's new feature, that was introduced in philss/floki#467 The initial idea is from philss/floki#463
philss
commented
Jun 15, 2023
| end | ||
|
|
||
| defp parse_dirty(html) do | ||
| case Html5ever.Native.parse_sync(html) do |
There was a problem hiding this comment.
For some reason we were calling the parse_sync function here. This may be a performance issue today.
|
I'm happy with this, so I'm going to merge. Please let me know if you find anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with Floki's new feature, that was introduced in philss/floki#467
The initial idea is from philss/floki#463
PS: this removes some unused code, adds
thiserroras dependency, and refactor a little bit the code.