Refs #1863 - show sass error messages in failed builds

phingofficial · Nov 18, 2024 · 7cee2b3 · 7cee2b3
1 parent 1c51e6e
commit 7cee2b3
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/src/Phing/Task/Ext/Sass/SassCompiler.php b/src/Phing/Task/Ext/Sass/SassCompiler.php
@@ -49,18 +49,11 @@ public function __construct(string $executable, string $flags)
      */
     public function compile(string $inputFilePath, string $outputFilePath, bool $failOnError): void
     {
-        try {
-            $output = $this->executeCommand($inputFilePath, $outputFilePath);
-            if ($failOnError && $output[0] !== 0) {
-                throw new BuildException(
-                    "Result returned as not 0. Result: {$output[0]}",
-                    Project::MSG_INFO
-                );
-            }
-        } catch (Exception $e) {
-            if ($failOnError) {
-                throw new BuildException($e);
-            }
+        list($return, $output) = $this->executeCommand($inputFilePath, $outputFilePath);
+        if ($failOnError && $return !== 0) {
+            throw new BuildException(
+                "Sass exited with return code {$return} and message '{$output[0]}'"
+            );
         }
     }