Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SassTask doesn't always show downstream errors (was SassCompiler ignores style) #1863

Closed
elt4n0 opened this issue Sep 3, 2024 · 1 comment
Milestone

Comments

@elt4n0
Copy link

elt4n0 commented Sep 3, 2024

Description
When the SassTask implements an instance of SassCompiler to execute instead of ScssPhpCompiler the style property passed is ignored.

Steps To Reproduce
Run a buildfile with a SassTask that contains a style property where SassTask::getExecutable() returns a non-null value. (e. g. when sass is installed globally using npm).

Expected behavior
The style parameter should be passed to whichever tool is being used to compile Sass.

@mrook mrook modified the milestones: 3.1.0, 3.0.1 Sep 4, 2024
@mrook
Copy link
Member

mrook commented Nov 18, 2024

Hi, style is actually passed on, but errors (when style is not a value that sass recognizes) are not returned correctly. Commit 7cee2b3 fixes this.

For example,

<sass style="compact" outputpath="." useSass="true" failOnError="true">
    <fileset dir="."/>
</sass>

now results in

BUILD FAILED
phing-tests/1863/build.xml:3:71 Sass exited with return code 64 and message '"compact" is not an allowed value for option "--style".'

@mrook mrook changed the title SassCompiler ignores style SassTask doesn't always show downstream errors (was SassCompiler ignores style) Dec 4, 2024
@mrook mrook closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants