Allow <.input type="checkbox"> without value attr in core compone…

…nts (#5427) * Allow `<.input type="checkbox">` without `value` attr in core components * Fix typo on assigns
phoenixframework · Oct 3, 2023 · 2c7fa8e · 2c7fa8e
1 parent 495a18d
commit 2c7fa8e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/installer/templates/phx_web/components/core_components.ex b/installer/templates/phx_web/components/core_components.ex
@@ -300,9 +300,9 @@ defmodule <%= @web_namespace %>.CoreComponents do
     |> input()
   end
 
-  def input(%{type: "checkbox", value: value} = assigns) do
+  def input(%{type: "checkbox"} = assigns) do
     assigns =
-      assign_new(assigns, :checked, fn -> Phoenix.HTML.Form.normalize_value("checkbox", value) end)
+      assign_new(assigns, :checked, fn -> Phoenix.HTML.Form.normalize_value("checkbox", assigns[:value]) end)
 
     ~H"""
     <div phx-feedback-for={@name}>

diff --git a/priv/templates/phx.gen.live/core_components.ex b/priv/templates/phx.gen.live/core_components.ex
@@ -300,9 +300,9 @@ defmodule <%= @web_namespace %>.CoreComponents do
     |> input()
   end
 
-  def input(%{type: "checkbox", value: value} = assigns) do
+  def input(%{type: "checkbox"} = assigns) do
     assigns =
-      assign_new(assigns, :checked, fn -> Phoenix.HTML.Form.normalize_value("checkbox", value) end)
+      assign_new(assigns, :checked, fn -> Phoenix.HTML.Form.normalize_value("checkbox", assigns[:value]) end)
 
     ~H"""
     <div phx-feedback-for={@name}>